apply default in objects and arrays #468
Conversation
|
@SiemelNaran Not sure if your PR is completed or not. If completed, could you please sync with the master so that we can easily compare the difference? @prashanthjos Could you please take a look at the PR to ensure it won't impact your use case? Thanks. |
I just rebased from upstream. |
|
@SiemelNaran we have an internal implementation of default keyword (which is not merged into this repo) in the Required validator where we add defaults for only required properties. Looks like we need to consider more complex scenarios like what should be the case if I have a property that refers to a definition through $ref and I have some defaults inside $ref. Should the walk populate the defaults from $ref. Looks this nesting logic is not implemented in your PR. Can you please confirm? |
My PR does not handle references. I could add support for that to my PR (then give me hint to an existing function that pulls properties from referred object into my object), or I can close my PR since you already have one. |
|
@SiemelNaran Please don't close the PR. You have reached this far and we really want to see this feature to be completed. I have just sent an invite to you to be a team member. Once accepted, you can create a feature branch here and merge your code into the branch. We can work together in the same branch. Let me know if any think I can do to assist. Thanks. |
|
Closed in view of #477 |
No description provided.