-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ValidationMessage.toString should contain all properties used for equality check #299
Comments
We have a pending issue with the error messages. It is still in active discussion but we are leaning to the specification recommendations. |
In case the ValidationMessage is changed to something containing more than the specification demands, there should be |
@koppor I think these methods all have their purposes. |
@stevehu Yeah, I think, the purposes are different. |
I agree with you that toString is used mostly internally like debugging or auditing. Lombok's toString generator looks pretty good; however, I don't think we should introduce another library for this purpose. In my opinion, we want to ensure that this library is as green as possible to not introduce any dependency conflict to users. We basically follow the same principle for the entire light platform. |
I am unit testing validation.
The test fails:
In IntelliJ, I can "Click to see the difference":
How can I quickly find out the differences without debugging?
Thus, I propose to include all properties in
toString
which are used atequals
.The text was updated successfully, but these errors were encountered: