Skip to content

Commit d1822d0

Browse files
authored
Feature/ci workflows (#145)
* chore: release prep for v1.24.1 * docs: updated changelog * fix: corrections to secret-scan.yml
1 parent 1b1fdf8 commit d1822d0

File tree

6 files changed

+44
-11
lines changed

6 files changed

+44
-11
lines changed

.github/workflows/secret-scan.yml

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ jobs:
1818
permissions:
1919
contents: read
2020
security-events: write
21+
issues: write
2122
steps:
2223
# ---------------------------------------------------------------------
2324
# Checkout the full repo history (needed for Gitleaks to scan all commits)
@@ -58,6 +59,13 @@ jobs:
5859
if: always()
5960
run: |
6061
echo "### 🧩 Gitleaks Scan Summary" >> $GITHUB_STEP_SUMMARY
62+
63+
# If the JSON report doesn't exist, that usually means no leaks were found.
64+
if [ ! -f gitleaks-report.json ]; then
65+
echo "✅ No leaks detected — Gitleaks did not generate a JSON report (expected behavior)." >> $GITHUB_STEP_SUMMARY
66+
exit 0
67+
fi
68+
6169
if [ -s gitleaks-report.json ]; then
6270
count=$(jq '.findings | length' gitleaks-report.json)
6371
if [ "$count" -gt 0 ]; then
@@ -71,7 +79,7 @@ jobs:
7179
echo "✅ No secrets detected." >> $GITHUB_STEP_SUMMARY
7280
fi
7381
else
74-
echo "⚠️ No report file found." >> $GITHUB_STEP_SUMMARY
82+
echo "⚠️ Report file exists but is empty." >> $GITHUB_STEP_SUMMARY
7583
fi
7684
7785
# ---------------------------------------------------------------------

.lighthouserc.cjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ This file is part of Network Pro.
99
module.exports = {
1010
ci: {
1111
collect: {
12-
url: ['https://netwk.pro'],
12+
url: ['https://audit.netwk.pro'],
1313
numberOfRuns: 1,
1414
settings: {
1515
onlyCategories: [

CHANGELOG.md

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,20 @@ This project attempts to follow [Keep a Changelog](https://keepachangelog.com/en
2222

2323
---
2424

25+
## [1.24.1]
26+
27+
### Changed
28+
29+
- Bumped project version to `v1.24.1`.
30+
- Updated **GitLeaks workflow** (`.github/workflows/secret-scan.yml`):
31+
- Reworked Gitleaks step to use official environment variables (`GITLEAKS_REPORT_PATH`, `GITLEAKS_LICENSE`) for compatibility with `gitleaks/gitleaks-action@v2`.
32+
- Added explicit handling for runs with no detected secrets (skips JSON parsing when no report is generated).
33+
- Improved summary step output with clear “No leaks detected” message and reduced false warnings.
34+
- Ensured consistent artifact uploads and safer fork-handling conditions.
35+
- Lighthouse now points to the new audit version of the site at [audit.netwk.pro](https://audit.netwk.pro).
36+
37+
---
38+
2539
## [1.24.0]
2640

2741
### Added

cspell.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@
6969
"prefs",
7070
"publickey",
7171
"reconsent",
72+
"sarif",
7273
"serv",
7374
"shizuku",
7475
"SIEM",

package-lock.json

Lines changed: 18 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@networkpro/web",
33
"private": false,
4-
"version": "1.24.0",
4+
"version": "1.24.1",
55
"description": "Locking Down Networks, Unlocking Confidence™ | Security, Networking, Privacy — Network Pro Strategies",
66
"keywords": [
77
"advisory",

0 commit comments

Comments
 (0)