Mach-O build version #95
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 4, 2024 13:14
pragma->tail is described as "anything after the operation", but existing parsing passed just the first whitespace-delimited word. Change the parsing to just strip leading and trailing white space off the rest of the line, but keep interior spaces if there are any. This is preparation for a build_version pragma for Mach-O matching the llvm-as .build_version syntax. Signed-off-by: Fabian Giesen <fabian.giesen@epicgames.com>
Matches the llvm-as .build_version syntax. Newer MacOS linker complains when object files don't contain a LC_BUILD_VERSION. Signed-off-by: Fabian Giesen <fabian.giesen@epicgames.com>
Signed-off-by: Fabian Giesen <fabian.giesen@epicgames.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a build_version directive for Mach-O emitting LC_BUILD_VERSION
Newer Xcode linkers warn when this is not present. This has overlap with issue #13,
but this implementation adds a
build_versiondirective matching llvm-as.build_versionsyntax to the Mach-O format. This is implemented as a pragma internally which
allows both specifying in the source (matching how it's normally used in llvm-as)
and on the command line via the
--pragmacommand-line option.I'm not aware of any "official" documentation of the llvm-as
.build_versionsyntax,so I worked off the parser in https://github.com/llvm/llvm-project/blob/main/llvm/lib/MC/MCParser/DarwinAsmParser.cpp