fix(dependency): mockito example replaced

Author: coursar

3.4_dependency/cart-with-mocks/pom.xml

@@ -15,22 +15,27 @@
     </properties>
 
     <dependencies>
+        <dependency>
+            <groupId>com.google.code.gson</groupId>
+            <artifactId>gson</artifactId>
+            <version>2.8.6</version>
+        </dependency>
         <dependency>
             <groupId>org.projectlombok</groupId>
             <artifactId>lombok</artifactId>
-            <version>1.18.12</version>
+            <version>1.18.16</version>
             <scope>provided</scope>
         </dependency>
         <dependency>
             <groupId>org.junit.jupiter</groupId>
             <artifactId>junit-jupiter</artifactId>
-            <version>5.4.2</version>
+            <version>5.7.0</version>
             <scope>test</scope>
         </dependency>
         <dependency>
             <groupId>org.mockito</groupId>
             <artifactId>mockito-junit-jupiter</artifactId>
-            <version>3.3.3</version>
+            <version>3.6.28</version>
             <scope>test</scope>
         </dependency>
     </dependencies>

3.4_dependency/cart-with-mocks/src/main/java/ru/netology/manager/CartManager.java

@@ -27,4 +27,12 @@ public PurchaseItem[] getAll() {
   public void removeById(int id) {
     repository.removeById(id);
   }
+
+  public int sum() {
+    int result = 0;
+    for (PurchaseItem item : getAll()) {
+      result = result + item.getProductPrice() * item.getCount();
+    }
+    return result;
+  }
 }

3.4_dependency/cart-with-mocks/src/main/java/ru/netology/repository/CartRepository.java

@@ -1,33 +1,66 @@
 package ru.netology.repository;
 
+import com.google.gson.Gson;
 import ru.netology.domain.PurchaseItem;
 
+import java.net.URI;
+import java.net.http.HttpClient;
+import java.net.http.HttpRequest;
+import java.net.http.HttpResponse;
+
 public class CartRepository {
-  private PurchaseItem[] items = new PurchaseItem[0];
+  private String dbUrl;
+  private HttpClient client = HttpClient.newHttpClient();
+  private Gson gson = new Gson();
+
+  public CartRepository(String dbUrl) {
+    this.dbUrl = dbUrl;
+  }
 
   public void save(PurchaseItem item) {
-    int length = items.length + 1;
-    PurchaseItem[] tmp = new PurchaseItem[length];
-    System.arraycopy(items, 0, tmp, 0, items.length);
-    int lastIndex = tmp.length - 1;
-    tmp[lastIndex] = item;
-    items = tmp;
+    try {
+      HttpRequest request = HttpRequest.newBuilder(URI.create(dbUrl))
+          .header("Content-Type", "application/json")
+          .POST(HttpRequest.BodyPublishers.ofString(gson.toJson(item)))
+          .build();
+      HttpResponse<String> response = client.send(request, HttpResponse.BodyHandlers.ofString());
+      if (response.statusCode() < 200 || response.statusCode() > 299) {
+        throw new RuntimeException("request didn't complete successfully");
+      }
+    } catch (Exception e) {
+      throw new RuntimeException(e);
+    }
   }
 
   public PurchaseItem[] findAll() {
-    return items;
+    try {
+      HttpRequest request = HttpRequest.newBuilder(URI.create(dbUrl))
+          .header("Accept", "application/json")
+          .GET()
+          .build();
+      HttpResponse<String> response = client.send(request, HttpResponse.BodyHandlers.ofString());
+      if (response.statusCode() < 200 || response.statusCode() > 299) {
+        throw new RuntimeException("request didn't complete successfully");
+      }
+      return gson.fromJson(response.body(), PurchaseItem[].class);
+    } catch (Exception e) {
+      throw new RuntimeException(e);
+    }
   }
 
   public void removeById(int id) {
-    int length = items.length - 1;
-    PurchaseItem[] tmp = new PurchaseItem[length];
-    int index = 0;
-    for (PurchaseItem item : items) {
-      if (item.getId() != id) {
-        tmp[index] = item;
-        index++;
+    try {
+      HttpRequest request = HttpRequest.newBuilder(URI.create(dbUrl + "/" + id))
+          .header("Content-Type", "application/json")
+          .DELETE()
+          .build();
+      HttpResponse<String> response = client.send(request, HttpResponse.BodyHandlers.ofString());
+      if (response.statusCode() < 200 || response.statusCode() > 299) {
+        throw new RuntimeException("request didn't complete successfully");
       }
+    } catch (Exception e) {
+      throw new RuntimeException(e);
     }
-    items = tmp;
   }
 }
+

3.4_dependency/cart-with-mocks/src/test/java/ru/netology/manager/CartManagerTestNonEmpty.java

@@ -1,6 +1,5 @@
 package ru.netology.manager;
 
-import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.extension.ExtendWith;
 import org.mockito.InjectMocks;
@@ -9,58 +8,32 @@
 import ru.netology.domain.PurchaseItem;
 import ru.netology.repository.CartRepository;
 
-import static org.junit.jupiter.api.Assertions.assertArrayEquals;
-import static org.mockito.Mockito.*;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.mockito.Mockito.doReturn;
+import static org.mockito.Mockito.verify;
 
 @ExtendWith(MockitoExtension.class)
 public class CartManagerTestNonEmpty {
   @Mock
   private CartRepository repository;
   @InjectMocks
   private CartManager manager;
-  private PurchaseItem first = new PurchaseItem(1, 1, "first", 1, 1);
-  private PurchaseItem second = new PurchaseItem(2, 2, "second", 1, 1);
-  private PurchaseItem third = new PurchaseItem(3, 3, "third", 1, 1);
-
-  @BeforeEach
-  public void setUp() {
-    manager.add(first);
-    manager.add(second);
-    manager.add(third);
-  }
+  private PurchaseItem first = new PurchaseItem(1, 1, "first", 100, 2);
+  private PurchaseItem second = new PurchaseItem(2, 2, "second", 10, 1);
+  private PurchaseItem third = new PurchaseItem(3, 3, "third", 1, 2);
 
   @Test
-  public void shouldRemoveIfExists() {
-    int idToRemove = 1;
+  public void shouldCalculateSum() {
     // настройка заглушки
-    PurchaseItem[] returned = new PurchaseItem[]{second, third};
-    doReturn(returned).when(repository).findAll();
-    doNothing().when(repository).removeById(idToRemove);
-
-    manager.removeById(idToRemove);
-    PurchaseItem[] expected = new PurchaseItem[]{third, second};
-    PurchaseItem[] actual = manager.getAll();
-    assertArrayEquals(expected, actual);
-
-    // удостоверяемся, что заглушка была вызвана с нужным значением
-    // но это уже проверка "внутренней" реализации
-    verify(repository).removeById(idToRemove);
-  }
-
-  @Test
-  public void shouldNotRemoveIfNotExists() {
-    int idToRemove = 4;
     PurchaseItem[] returned = new PurchaseItem[]{first, second, third};
     doReturn(returned).when(repository).findAll();
-    doNothing().when(repository).removeById(idToRemove);
 
-    manager.removeById(idToRemove);
-    PurchaseItem[] expected = new PurchaseItem[]{third, second, first};
-    PurchaseItem[] actual = manager.getAll();
+    int expected = 212;
+    int actual = manager.sum();
+    assertEquals(expected, actual);
 
-    assertArrayEquals(expected, actual);
-    // удостоверяемся, что заглушка была вызвана с нужным значением
+    // удостоверяемся, что заглушка была вызвана
     // но это уже проверка "внутренней" реализации
-    verify(repository).removeById(idToRemove);
+    verify(repository).findAll();
   }
-}
+}