Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align build steps - distinguish clean vs dev builds #745

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

jotak
Copy link
Member

@jotak jotak commented Oct 29, 2024

  • Reducing the Dockerfile dependencies allows faster dev builds
  • Rename target build_code -> compile for consistency
  • Remove now useless validate_go target
  • Remove confgenerator from docker images (we may introduce another dockerfile if someone finds it useful and want it back)

- Reducing the Dockerfile dependencies allows faster dev builds
- Rename target build_code -> compile for consistency
- Remove now useless validate_go target
- Remove confgenerator from docker images (we may introduce another
  dockerfile if someone finds it useful and want it back)
@jotak jotak added no-qe This PR doesn't necessitate QE approval no-doc This PR doesn't require documentation change on the NetObserv operator labels Oct 29, 2024
Copy link

openshift-ci bot commented Oct 29, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jotak. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.38%. Comparing base (753c34a) to head (8882e0f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #745      +/-   ##
==========================================
- Coverage   64.39%   64.38%   -0.01%     
==========================================
  Files         108      108              
  Lines        8303     8301       -2     
==========================================
- Hits         5347     5345       -2     
  Misses       2638     2638              
  Partials      318      318              
Flag Coverage Δ
unittests 64.38% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
cmd/confgenerator/main.go 61.79% <100.00%> (-0.43%) ⬇️
cmd/flowlogs-pipeline/main.go 54.33% <100.00%> (-0.36%) ⬇️

@openshift-ci openshift-ci bot added the lgtm label Nov 5, 2024
@jotak jotak merged commit 592f367 into netobserv:main Nov 5, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm no-doc This PR doesn't require documentation change on the NetObserv operator no-qe This PR doesn't necessitate QE approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants