Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make expiryTime in encode_prom a Time object #382

Closed
KalmanMeth opened this issue Feb 9, 2023 · 0 comments · Fixed by #411
Closed

make expiryTime in encode_prom a Time object #382

KalmanMeth opened this issue Feb 9, 2023 · 0 comments · Fixed by #411

Comments

@KalmanMeth
Copy link
Collaborator

We use timeouts in various places. In connection tracking, we use Time objects. In prometheus encoder, we use seconds. Make them consistent throughout the code.
@KalmanMeth KalmanMeth linked a pull request Mar 26, 2023 that will close this issue
make expiryTime in encode_prom into a Duration #411
Merged
@ronensc ronensc changed the title make expirtyTime in encode_prom a Time object make expiryTime in encode_prom a Time object Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

make expiryTime in encode_prom into a Duration KalmanMeth/flowlogs2metrics
1 participant
@KalmanMeth