Skip to content

Commit 89dc80b

Browse files
clear native cred pointer after transfer ownership to libgit
1 parent 033ad6e commit 89dc80b

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

remote.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -254,9 +254,11 @@ func credentialsCallback(_cred **C.git_cred, _url *C.char, _username_from_url *C
254254
return C.GIT_EUSER
255255
}
256256
if cred != nil {
257-
// we are transferring ownership to libgit, have to disable
258-
runtime.SetFinalizer(cred, nil)
259257
*_cred = cred.ptr
258+
259+
// have transferred ownership to libgit, 'forget' the native pointer
260+
cred.ptr = nil
261+
runtime.SetFinalizer(cred, nil)
260262
}
261263
return 0
262264
}

0 commit comments

Comments
 (0)