fix incorrect _headers syntax & broken local cypress

Author: lindsaylevine

cypress/plugins/deployProject.js

@@ -1,3 +1,4 @@
+const { removeSync } = require("fs-extra");
 const waitOn = require("wait-on");
 const execa = require("execa");
 const { join } = require("path");
@@ -7,6 +8,9 @@ const getBaseUrl = require("./getBaseUrl");
 const deployLocally = ({ project }, config) => {
   process.stdout.write(`Deploying project: ${project}...`);
 
+  // _headers breaks netlify dev
+  removeSync(join(config.buildsFolder, project, "out_publish", "_headers"));
+
   // Start server. Must start in detached mode, so that we can kill it later.
   // Otherwise, we seem unable to kill it.
   // See: https://medium.com/@almenon214/killing-processes-with-node-772ffdd19aad

lib/steps/setupHeaders.js

@@ -19,10 +19,16 @@ const setupHeaders = (publishPath) => {
 
   // Add rule to override cache control for static chunks
   const staticChunkRule = [
-    `/_next/static/chunks/*:`,
+    `/*/_next/static/chunks/*`,
     `\n`,
     `  `,
-    `cache-control: public,max-age=31536000,immutable`,
+    `cache-control: public`,
+    `\n`,
+    `  `,
+    `cache-control: max-age=31536000`,
+    `\n`,
+    `  `,
+    `cache-control: immutable`,
   ].join("");
   headers.push(staticChunkRule);
 

tests/__snapshots__/defaults.test.js.snap

@@ -2,8 +2,10 @@
 
 exports[`Headers creates Netlify headers 1`] = `
 "# Next-on-Netlify Headers
-/_next/static/chunks/*:
-  cache-control: public,max-age=31536000,immutable"
+/*/_next/static/chunks/*
+  cache-control: public
+  cache-control: max-age=31536000
+  cache-control: immutable"
 `;
 
 exports[`Routing creates Netlify redirects 1`] = `