Skip to content
This repository was archived by the owner on Oct 10, 2022. It is now read-only.

feat!: remove deploy method #437

Merged
merged 3 commits into from
May 27, 2021
Merged

feat!: remove deploy method #437

merged 3 commits into from
May 27, 2021

Conversation

eduardoboucas
Copy link
Member

- Summary

Removes the deploy method, as it was added to the CLI.

Closes #157.

@eduardoboucas eduardoboucas added the type: feature code contributing to the implementation of a feature and/or user facing functionality label May 26, 2021
Copy link
Contributor

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@eduardoboucas
Copy link
Member Author

@erezrokah I've updated the README in a3cfa1d. Could you give it a final 👀 and ✅ , please?

@erezrokah
Copy link
Contributor

@erezrokah I've updated the README in a3cfa1d. Could you give it a final 👀 and ✅ , please?

Arg, I always forget the readme changes. Nice catch!

@CEbbinghaus
Copy link

I know this is done and dusted but I'm wondering why?
It seems to me that there isn't a reason it could exist in both packages.

Now instead of being able to directly call the function through js and pass the parameters as the arguments to a function, I have to build a string command and run it via child_process.exec.

is there any security risk and if not it is not advised to use <7.0.0 versions since that would be my next step.

@erezrokah
Copy link
Contributor

Hi @CEbbinghaus, you can see the reasoning in the related issue #157.

is there any security risk and if not it is not advised to use <7.0.0 versions since that would be my next step.

We don't update dependencies nor back-port new features to older versions. So if there's a vulnerable dependency it will still be a part of the older version.

@IanVS
Copy link

IanVS commented Oct 14, 2021

I'm also wondering about the reasoning for this, as it wasn't clear to me in #157. I'm building an AWS lambda function to publish netlify deploys, and not being able to use the js client is a disappointment.

This seems out of place for a client that should be wrapping our open-api spec.

was the only rationale I could find, but I don't understand the reasoning.

Edit: I think I got myself a bit confused. I don't want to deploy, I want to publish a deploy. Which I guess the /api/v1/sites/{site_id}/deploys/{deploy_id}/restore endpoint is used for (?), and I assume can be done through the client.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: consider moving js-client deploy logic to the CLI
4 participants