This repository has been archived by the owner on Oct 10, 2022. It is now read-only.
feat(command-deploy): support hidden deployment folders #150
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
This PR aims to fix an issue opened in the
netlify/cli
repository: netlify/cli#1227The issue here is that the
defaultFilter
function aims to ignore hidden files within the deploy directory (which makes sense). Since it is not aware of the actual name of the deploy directory, it currently filters out the directory itself.By creating a closure to encapsulate the new
deployDir
option, we can pass the name of the deploy folder into the filter and allow filtering inside that folder.- Test plan
Given these steps, Netlify should properly find and hash the files inside
.build
- Description for the changelog
feat(command-deploy): support hidden deployment folders with
-d
flag- A picture of a cute animal (not mandatory but encouraged)