Skip to content
This repository has been archived by the owner on Oct 10, 2022. It is now read-only.

feat(command-deploy): support hidden deployment folders #150

Closed
wants to merge 1 commit into from
Closed

feat(command-deploy): support hidden deployment folders #150

wants to merge 1 commit into from

Conversation

monsonjeremy
Copy link

- Summary

This PR aims to fix an issue opened in the netlify/cli repository: netlify/cli#1227

The issue here is that the defaultFilter function aims to ignore hidden files within the deploy directory (which makes sense). Since it is not aware of the actual name of the deploy directory, it currently filters out the directory itself.

By creating a closure to encapsulate the new deployDir option, we can pass the name of the deploy folder into the filter and allow filtering inside that folder.

- Test plan

npx @docusaurus/init@next init my-website classic
cd my-website
mkdir .build
vim .build/index.html

# Insert some HTML into the file and save it
netlify deploy -d .build

Given these steps, Netlify should properly find and hash the files inside .build

- Description for the changelog

feat(command-deploy): support hidden deployment folders with -d flag

- A picture of a cute animal (not mandatory but encouraged)

luna

@erezrokah
Copy link
Contributor

Closing, see netlify/cli#1230 (comment)

@erezrokah erezrokah closed this Sep 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants