Merge pull request #212 from netlify/lint/array-callback-return

Enable `array-callback-return` ESLint rule

Author: ehmicky

.eslintrc.js

@@ -4,7 +4,6 @@ module.exports = {
   extends: '@netlify/eslint-config-node',
   rules: {
     // TODO: enable those rules
-    'array-callback-return': 0,
     complexity: 0,
     'consistent-this': 0,
     'id-length': 0,

src/deploy/hash-files.test.js

@@ -10,9 +10,13 @@ test('hashes files in a folder', async (t) => {
     filter: defaultFilter,
   })
   t.truthy(files['netlify.toml'], 'includes the netlify.toml file')
-  Object.keys(files).forEach((path) => t.truthy(path, 'each file has a path'))
+  Object.keys(files).forEach((path) => {
+    t.truthy(path, 'each file has a path')
+  })
   t.truthy(filesShaMap, 'filesShaMap is returned')
-  Object.values(filesShaMap).forEach((fileObjArray) =>
-    fileObjArray.forEach((fileObj) => t.truthy(fileObj.normalizedPath, 'fileObj have a normalizedPath field')),
-  )
+  Object.values(filesShaMap).forEach((fileObjArray) => {
+    fileObjArray.forEach((fileObj) => {
+      t.truthy(fileObj.normalizedPath, 'fileObj have a normalizedPath field')
+    })
+  })
 })

src/deploy/hash-fns.test.js

@@ -7,9 +7,13 @@ const { defaultFilter } = require('./util')
 test('hashes files in a folder', async (t) => {
   const { functions, fnShaMap } = await hashFns(__dirname, { filter: defaultFilter, tmpDir: tempy.directory() })
 
-  Object.keys(functions).forEach((path) => t.truthy(path, 'each file has a path'))
+  Object.keys(functions).forEach((path) => {
+    t.truthy(path, 'each file has a path')
+  })
   t.truthy(fnShaMap, 'fnShaMap is returned')
-  Object.values(fnShaMap).forEach((fileObjArray) =>
-    fileObjArray.forEach((fileObj) => t.truthy(fileObj.normalizedPath, 'fileObj have a normalizedPath field')),
-  )
+  Object.values(fnShaMap).forEach((fileObjArray) => {
+    fileObjArray.forEach((fileObj) => {
+      t.truthy(fileObj.normalizedPath, 'fileObj have a normalizedPath field')
+    })
+  })
 })

src/deploy/util.test.js

@@ -62,5 +62,7 @@ test('pass empty name to defaultFilter', (t) => {
       expect: true,
     },
   ]
-  cases.forEach((c) => t.is(defaultFilter(c.input), c.expect))
+  cases.forEach((c) => {
+    t.is(defaultFilter(c.input), c.expect)
+  })
 })