fix(whiteboard): don't set state when not writable #1607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
hyrious
commented
Jul 14, 2022
hyrious
commented
- errorTips: improve error log
- errorTips: improve error log
BlackHole1
approved these changes
Jul 14, 2022
hyrious
added a commit
that referenced
this pull request
Jul 28, 2022
- errorTips: improve error log
BlackHole1
added a commit
that referenced
this pull request
Jul 28, 2022
BlackHole1
added a commit
that referenced
this pull request
Jul 29, 2022
* fix(whiteboard): don't set state when not writable (#1607) (#1616) - errorTips: improve error log Co-authored-by: hyrious <hyrious@outlook.com> * refactor(classroom): add down stage all * ci(ci): update ci build branch * refactor(classroom): only show down stage all button on creator side * refactor(project): edit feedback link (#1587) * fix(classroom): disable camera and mic on down stage * chore(version): upgrade version to v1.8.3 Co-authored-by: hyrious <hyrious@outlook.com> Co-authored-by: CRIMX <straybugs@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.