Merge pull request #22 from netinvent/encoding-hotfix

Encoding hotfix

Author: deajan

.github/workflows/linux.yaml

@@ -10,12 +10,13 @@ jobs:
       matrix:
         os: [ubuntu-latest]
         # Python 3.3 and 3.4 have been removed since github won't provide these anymore
-        python-version: [2.7, 3.5, 3.6, 3.7, 3.8, 3.9, "3.10", 'pypy-3.6', 'pypy-3.7', 'pypy-3.8']
+        # As of 2023/01/09, we have removed python 3.5 and 3.6 as they don't work anymore with linux on github
+        python-version: [2.7, 3.7, 3.8, 3.9, "3.10", "3.11", 'pypy-3.6', 'pypy-3.7', 'pypy-3.8']
 
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v3
     - name: Set up Python ${{ matrix.python-version }}
-      uses: actions/setup-python@v2
+      uses: actions/setup-python@v3
       with:
         python-version: ${{ matrix.python-version }}
     - name: Install dependencies
@@ -30,4 +31,4 @@ jobs:
         pip install pytest coverage
         python -m coverage run -m pytest -vvs tests
     - name: Upload Coverage to Codecov
-      uses: codecov/codecov-action@v1
+      uses: codecov/codecov-action@v3

.github/workflows/windows.yaml

@@ -14,12 +14,12 @@ jobs:
     strategy:
       matrix:
         os: [windows-latest]
-        python-version: [2.7, 3.5, 3.6, 3.7, 3.8, 3.9, "3.10", 'pypy-3.6', 'pypy-3.7', 'pypy-3.8']
+        python-version: [2.7, 3.5, 3.6, 3.7, 3.8, 3.9, "3.10", "3.11", 'pypy-3.6', 'pypy-3.7', 'pypy-3.8']
 
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v3
     - name: Set up Python ${{ matrix.python-version }}
-      uses: actions/setup-python@v2
+      uses: actions/setup-python@v3
       with:
         python-version: ${{ matrix.python-version }}
     - name: Install dependencies
@@ -34,4 +34,4 @@ jobs:
         pip install pytest coverage
         python -m coverage run -m pytest -vvs tests
     - name: Upload Coverage to Codecov
-      uses: codecov/codecov-action@v1
+      uses: codecov/codecov-action@v3

CHANGELOG.md

@@ -1,3 +1,7 @@
+# v1.4.1 - command and conquer them all, don't nod
+
+- Fix endoding always was set to os default unless explicitly disabled by setting `encoding=False`
+
 # v1.4.0 - command and conquer them all
 
 ## Features

LICENSE

@@ -1,6 +1,6 @@
 BSD 3-Clause License
 
-Copyright (c) 2015-2022, netinvent, Orsiris de Jong, contact@netinvent.fr
+Copyright (c) 2015-2023, netinvent, Orsiris de Jong, contact@netinvent.fr
 All rights reserved.
 
 Redistribution and use in source and binary forms, with or without

README.md

@@ -20,7 +20,7 @@ while solving various problems a developer may face among:
    - Optional Windows UAC elevation module compatible with CPython, PyInstaller & Nuitka
    - Optional Linux sudo elevation compatible with CPython, PyInstaller & Nuitka
 
-It is compatible with Python 2.7+ (backports some newer Python 3.5 functionality) and is tested on both Linux and Windows.
+It is compatible with Python 2.7+, tested up to Python 3.11 (backports some newer Python 3.5 functionality) and is tested on both Linux and Windows.
 It is also compatible with PyPy Python implementation.
 ...and yes, keeping Python 2.7 compatibility has proven to be quite challenging.
 
@@ -98,7 +98,7 @@ exit_code, output = command_runner(command, encoding='unicode_escape')
 
 Earlier subprocess.popen implementations didn't have an encoding setting so command_runner will deal with encoding for those.
 
-You can also disable command_runner's encoding in order to get raw process output (bytes) by passing False boolean.
+You can also disable command_runner's internal encoding in order to get raw process output (bytes) by passing False boolean.
 
 Example:
 ```python
@@ -403,6 +403,21 @@ It also uses the following standard arguments:
 
 **Note that ALL other subprocess.Popen arguments are supported, since they are directly passed to subprocess.**
 
+### logging
+
+Even muted, `command_runner` will still log errors.
+If you want to completely mute `command_runner`, you will have to set it's logger instance to `logger.CRITICAL` level, since this level is never called.
+
+Example of entirely muted `command_runner` execution:
+```
+rom command_runner import command_runner
+import logging
+
+logging.getLogger("command_runner").setLevel(logging.CRITICAL)
+
+err_code, stdout, stderr = command_runner("ping 127.0.0.1", timeout=1, method='monitor', live_output=False, stdout=False, stderr=False, split_streams=True)
+```
+
 ## UAC Elevation / sudo elevation
 
 command_runner package allowing privilege elevation.

command_runner/__init__.py

@@ -19,10 +19,10 @@
 
 __intname__ = "command_runner"
 __author__ = "Orsiris de Jong"
-__copyright__ = "Copyright (C) 2015-2022 Orsiris de Jong"
+__copyright__ = "Copyright (C) 2015-2023 Orsiris de Jong for NetInvent SASU"
 __licence__ = "BSD 3 Clause"
-__version__ = "1.4.0"
-__build__ = "2022053001"
+__version__ = "1.4.1"
+__build__ = "2023010901"
 __compat__ = "python2.7+"
 
 import io
@@ -384,7 +384,7 @@ def command_runner(
     # cp437 encoding assures we catch most special characters from cmd.exe
     # Unless encoding=False in which case nothing gets encoded except Exceptions and logger strings for Python 2
     error_encoding = "cp437" if os.name == "nt" else "utf-8"
-    if encoding is not False:
+    if encoding is None:
         encoding = error_encoding
 
     # Fix when unix command was given as single string