chore: add code coverage to orb backends #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoparente
requested review from
ltucker,
mfiedorowicz,
jajeffries and
rboucher-me
|
Go test coverage
Total coverage: 60.7% |
jajeffries
approved these changes
Apr 8, 2025
mfiedorowicz
approved these changes
Apr 8, 2025
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several new test cases for various backend components and includes some minor fixes and improvements. The most significant changes include the addition of new test files for device discovery, network discovery, and pktvisor backends, as well as updates to existing tests to simulate process output and correct URL formatting.
New test cases:
agent/backend/devicediscovery/device_discovery_test.go: Added comprehensive tests for the DeviceDiscovery backend, including server setup, backend configuration, and policy application.agent/backend/networkdiscovery/network_discovery_test.go: Added comprehensive tests for the NetworkDiscovery backend, including server setup, backend configuration, and policy application.agent/backend/pktvisor/pktvisor_test.go: Added comprehensive tests for the Pktvisor backend, including server setup, backend configuration, and policy application.Updates to existing tests:
agent/backend/mocks/mocks.go: UpdatedSetupSuccessfulProcessto simulate process output by sending "success" to stdout and "error" to stderr.agent/backend/otel/otel_test.go: Added capabilities and policy handling to the OpenTelemetry backend test. [1] [2]Minor fixes:
agent/backend/pktvisor/pktvisor.go: Corrected URL formatting for various API endpoints by using the correct port variable. [1] [2] [3] [4] [5]