Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace custom HTMX tooling with django-htmx #14735

Closed
jeremystretch opened this issue Jan 8, 2024 · 0 comments
Closed

Replace custom HTMX tooling with django-htmx #14735

jeremystretch opened this issue Jan 8, 2024 · 0 comments
Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user
Milestone
v4.0

Comments

@jeremystretch
Copy link
Member

Proposed Changes

NetBox currently employs HTMX for dynamic rendering of certain UI views. This issue proposes replacing our related custom tooling (e.g. is_htmx()) with functionality provided by the django-htmx package.

Justification

Now that we've committed to using HTMX for enabling a more responsive UI, it makes sense to adopt a library dedicated to supporting HTMX operations and avoid reinventing the wheel.
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user labels Jan 8, 2024
@jeremystretch jeremystretch added this to the v4.0 milestone Jan 8, 2024
@jeremystretch jeremystretch changed the title Implement django-htmx Replace custom HTMX tooling with django-htmx Jan 8, 2024
@jeremystretch jeremystretch mentioned this issue Jan 8, 2024
Closed
@jeremystretch jeremystretch mentioned this issue Jan 19, 2024
Merged
jeremystretch added a commit that referenced this issue Jan 22, 2024
@jeremystretch
Closes #14735: Implement django-htmx (#14873)
1d41a8a 
* Install django-htmx

* Replace is_htmx() function with request.htmx

* Remove is_embedded() HTMX utility

* Include django-htmx debug error handler
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user
Projects
None yet
Milestone
v4.0
Development

No branches or pull requests
1 participant
@jeremystretch