Skip to content

Commit 8be7ba6

Browse files
authored
Fix iprangeclaim IpRangeName status field yaml/json name (#371)
Fixes the mismatch of go and json field in `IpRangeName`.
1 parent 85bdc1b commit 8be7ba6

File tree

8 files changed

+19
-19
lines changed

8 files changed

+19
-19
lines changed

api/v1/iprangeclaim_types.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ type IpRangeClaimStatus struct {
105105
EndAddressDotDecimal string `json:"endAddressDotDecimal,omitempty"`
106106

107107
// The name of the IpRange CR created by the IpRangeClaim Controller
108-
IpRangeName string `json:"ipAddressName,omitempty"`
108+
IpRangeName string `json:"ipRangeName,omitempty"`
109109

110110
// Conditions represent the latest available observations of an object's state
111111
Conditions []metav1.Condition `json:"conditions,omitempty" patchStrategy:"merge" patchMergeKey:"type" protobuf:"bytes,1,rep,name=conditions"`

config/crd/bases/netbox.dev_iprangeclaims.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -198,10 +198,6 @@ spec:
198198
endAddressDotDecimal:
199199
description: The last IP Addresses in Dot Decimal notation
200200
type: string
201-
ipAddressName:
202-
description: The name of the IpRange CR created by the IpRangeClaim
203-
Controller
204-
type: string
205201
ipAddresses:
206202
description: The full list of IP Addresses in CIDR notation
207203
items:
@@ -218,6 +214,10 @@ spec:
218214
ipRangeDotDecimal:
219215
description: The assigned IP Range in Dot Decimal notation (e.g. 192.168.0.1-192.168.0.123)
220216
type: string
217+
ipRangeName:
218+
description: The name of the IpRange CR created by the IpRangeClaim
219+
Controller
220+
type: string
221221
startAddress:
222222
description: The first IP Addresses in CIDR notation
223223
type: string

tests/e2e/iprange/ipv4/iprangeclaim-ipv4-apply-update/chainsaw-test.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ spec:
3535
- status: 'True'
3636
endAddress: 3.2.0.30/32
3737
endAddressDotDecimal: 3.2.0.30
38-
ipAddressName: iprangeclaim-ipv4-apply-update
38+
ipRangeName: iprangeclaim-ipv4-apply-update
3939
ipRange: 3.2.0.1/32-3.2.0.30/32
4040
ipRangeDotDecimal: 3.2.0.1-3.2.0.30
4141
startAddress: 3.2.0.1/32
@@ -89,7 +89,7 @@ spec:
8989
- status: 'True'
9090
endAddress: 3.2.0.30/32
9191
endAddressDotDecimal: 3.2.0.30
92-
ipAddressName: iprangeclaim-ipv4-apply-update
92+
ipRangeName: iprangeclaim-ipv4-apply-update
9393
ipRange: 3.2.0.1/32-3.2.0.30/32
9494
ipRangeDotDecimal: 3.2.0.1-3.2.0.30
9595
startAddress: 3.2.0.1/32

tests/e2e/iprange/ipv4/iprangeclaim-ipv4-prefixexhausted/chainsaw-test.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ spec:
3030
- status: 'True'
3131
endAddress: 3.2.1.30/32
3232
endAddressDotDecimal: 3.2.1.30
33-
ipAddressName: iprangeclaim-ipv4-prefixexhausted-1
33+
ipRangeName: iprangeclaim-ipv4-prefixexhausted-1
3434
ipRange: 3.2.1.1/32-3.2.1.30/32
3535
ipRangeDotDecimal: 3.2.1.1-3.2.1.30
3636
startAddress: 3.2.1.1/32
@@ -80,7 +80,7 @@ spec:
8080
- status: 'True'
8181
endAddress: 3.2.1.60/32
8282
endAddressDotDecimal: 3.2.1.60
83-
ipAddressName: iprangeclaim-ipv4-prefixexhausted-2
83+
ipRangeName: iprangeclaim-ipv4-prefixexhausted-2
8484
ipRange: 3.2.1.31/32-3.2.1.60/32
8585
ipRangeDotDecimal: 3.2.1.31-3.2.1.60
8686
startAddress: 3.2.1.31/32

tests/e2e/iprange/ipv4/iprangeclaim-ipv4-restore/chainsaw-test.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ spec:
3131
- status: 'True'
3232
endAddress: 3.2.2.30/32
3333
endAddressDotDecimal: 3.2.2.30
34-
ipAddressName: iprangeclaim-ipv4-restore-1
34+
ipRangeName: iprangeclaim-ipv4-restore-1
3535
ipRange: 3.2.2.1/32-3.2.2.30/32
3636
ipRangeDotDecimal: 3.2.2.1-3.2.2.30
3737
startAddress: 3.2.2.1/32
@@ -91,7 +91,7 @@ spec:
9191
- status: 'True'
9292
endAddress: 3.2.2.60/32
9393
endAddressDotDecimal: 3.2.2.60
94-
ipAddressName: iprangeclaim-ipv4-restore-2
94+
ipRangeName: iprangeclaim-ipv4-restore-2
9595
ipRange: 3.2.2.31/32-3.2.2.60/32
9696
ipRangeDotDecimal: 3.2.2.31-3.2.2.60
9797
startAddress: 3.2.2.31/32
@@ -143,7 +143,7 @@ spec:
143143
- status: 'True'
144144
endAddress: 3.2.2.30/32
145145
endAddressDotDecimal: 3.2.2.30
146-
ipAddressName: iprangeclaim-ipv4-restore-1
146+
ipRangeName: iprangeclaim-ipv4-restore-1
147147
ipRange: 3.2.2.1/32-3.2.2.30/32
148148
ipRangeDotDecimal: 3.2.2.1-3.2.2.30
149149
startAddress: 3.2.2.1/32

tests/e2e/iprange/ipv6/iprangeclaim-ipv6-apply-update/chainsaw-test.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ spec:
3535
- status: 'True'
3636
endAddress: 3:2::1e/128
3737
endAddressDotDecimal: 3:2::1e
38-
ipAddressName: iprangeclaim-ipv6-apply-update
38+
ipRangeName: iprangeclaim-ipv6-apply-update
3939
ipRange: 3:2::1/128-3:2::1e/128
4040
ipRangeDotDecimal: 3:2::1-3:2::1e
4141
startAddress: 3:2::1/128
@@ -89,7 +89,7 @@ spec:
8989
- status: 'True'
9090
endAddress: 3:2::1e/128
9191
endAddressDotDecimal: 3:2::1e
92-
ipAddressName: iprangeclaim-ipv6-apply-update
92+
ipRangeName: iprangeclaim-ipv6-apply-update
9393
ipRange: 3:2::1/128-3:2::1e/128
9494
ipRangeDotDecimal: 3:2::1-3:2::1e
9595
startAddress: 3:2::1/128

tests/e2e/iprange/ipv6/iprangeclaim-ipv6-prefixexhausted/chainsaw-test.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ spec:
3030
- status: 'True'
3131
endAddress: 3:2:1::1e/128
3232
endAddressDotDecimal: 3:2:1::1e
33-
ipAddressName: iprangeclaim-ipv6-prefixexhausted-1
33+
ipRangeName: iprangeclaim-ipv6-prefixexhausted-1
3434
ipRange: 3:2:1::1/128-3:2:1::1e/128
3535
ipRangeDotDecimal: 3:2:1::1-3:2:1::1e
3636
startAddress: 3:2:1::1/128
@@ -81,7 +81,7 @@ spec:
8181
- status: 'True'
8282
endAddress: 3:2:1::3c/128
8383
endAddressDotDecimal: 3:2:1::3c
84-
ipAddressName: iprangeclaim-ipv6-prefixexhausted-2
84+
ipRangeName: iprangeclaim-ipv6-prefixexhausted-2
8585
ipRange: 3:2:1::1f/128-3:2:1::3c/128
8686
ipRangeDotDecimal: 3:2:1::1f-3:2:1::3c
8787
startAddress: 3:2:1::1f/128

tests/e2e/iprange/ipv6/iprangeclaim-ipv6-restore/chainsaw-test.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ spec:
3131
- status: 'True'
3232
endAddress: 3:2:2::1e/128
3333
endAddressDotDecimal: 3:2:2::1e
34-
ipAddressName: iprangeclaim-ipv6-restore-1
34+
ipRangeName: iprangeclaim-ipv6-restore-1
3535
ipRange: 3:2:2::1/128-3:2:2::1e/128
3636
ipRangeDotDecimal: 3:2:2::1-3:2:2::1e
3737
startAddress: 3:2:2::1/128
@@ -91,7 +91,7 @@ spec:
9191
- status: 'True'
9292
endAddress: 3:2:2::3c/128
9393
endAddressDotDecimal: 3:2:2::3c
94-
ipAddressName: iprangeclaim-ipv6-restore-2
94+
ipRangeName: iprangeclaim-ipv6-restore-2
9595
ipRange: 3:2:2::1f/128-3:2:2::3c/128
9696
ipRangeDotDecimal: 3:2:2::1f-3:2:2::3c
9797
startAddress: 3:2:2::1f/128
@@ -143,7 +143,7 @@ spec:
143143
- status: 'True'
144144
endAddress: 3:2:2::1e/128
145145
endAddressDotDecimal: 3:2:2::1e
146-
ipAddressName: iprangeclaim-ipv6-restore-1
146+
ipRangeName: iprangeclaim-ipv6-restore-1
147147
ipRange: 3:2:2::1/128-3:2:2::1e/128
148148
ipRangeDotDecimal: 3:2:2::1-3:2:2::1e
149149
startAddress: 3:2:2::1/128

0 commit comments

Comments
 (0)