Skip to content

Commit 46310fa

Browse files
authored
Distinguish if error occurd or if no matching prefix was found (#346)
distinguish if error occurd or if no matching prefix was found
1 parent 2c0a1c5 commit 46310fa

File tree

1 file changed

+9
-2
lines changed

1 file changed

+9
-2
lines changed

internal/controller/prefixclaim_controller.go

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -155,12 +155,19 @@ func (r *PrefixClaimReconciler) Reconcile(ctx context.Context, req ctrl.Request)
155155

156156
// fetch available prefixes from netbox
157157
parentPrefixCandidates, err := r.NetboxClient.GetAvailablePrefixesByParentPrefixSelector(&prefixClaim.Spec)
158-
if err != nil || len(parentPrefixCandidates) == 0 {
158+
if err != nil {
159159
r.EventStatusRecorder.Recorder().Event(prefixClaim, corev1.EventTypeWarning, netboxv1.ConditionPrefixAssignedFalse.Reason, netboxv1.ConditionPrefixAssignedFalse.Message+": "+err.Error())
160160
if err := r.EventStatusRecorder.Report(ctx, prefixClaim, netboxv1.ConditionPrefixAssignedFalse, corev1.EventTypeWarning, err); err != nil {
161161
return ctrl.Result{}, err
162162
}
163-
163+
return ctrl.Result{Requeue: true}, nil
164+
}
165+
if len(parentPrefixCandidates) == 0 {
166+
message := "no parent prefix found matching the parenPrefixSelector"
167+
r.EventStatusRecorder.Recorder().Event(prefixClaim, corev1.EventTypeWarning, netboxv1.ConditionPrefixAssignedFalse.Reason, netboxv1.ConditionPrefixAssignedFalse.Message+": "+message)
168+
if err := r.EventStatusRecorder.Report(ctx, prefixClaim, netboxv1.ConditionPrefixAssignedFalse, corev1.EventTypeWarning, errors.New(message)); err != nil {
169+
return ctrl.Result{}, err
170+
}
164171
// we requeue as this might be a temporary prefix exhausation
165172
return ctrl.Result{Requeue: true}, nil
166173
}

0 commit comments

Comments
 (0)