netbox_inventory_item: Allow assigning a component #1020
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@btriller I apologize if this is inappropriate since I'm still new to contributing but I noticed this PR has been open for sometime. I'd like to have this feature in the next version so perhaps I can help by completing the unit tests. Cheers |
|
@ahlee1 haven't seen the original author come back, so please do feel free to open a new PR that incorporates these changes and unit tests that you write. |
|
This has been completed in #1078 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
New Behavior
Allow assigning a component to an inventory_item.
Contrast to Current Behavior
...
Discussion: Benefits and Drawbacks
Benefit: Users can optionally assign the component to an inventory_item.
Drawbacks: None
Changes to the Documentation
Documentation for the new parameters are included in the PR.
Proposed Release Note Entry
...
Double Check
develbranch.