Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

landlock: Leftover from #5315 #5354

Open
14 tasks
rusty-snake opened this issue Sep 1, 2022 · 3 comments
Open
14 tasks

landlock: Leftover from #5315 #5354

rusty-snake opened this issue Sep 1, 2022 · 3 comments

Comments

@rusty-snake
Copy link
Collaborator

cc @kmk3 @ChrysoliteAzalea

@kmk3
Copy link
Collaborator

kmk3 commented Sep 2, 2022

@rusty-snake

Thanks for making a checklist.

To be clear, I still think that reverting #5315 now and letting
@ChrysoliteAzalea resubmit it afterwards is the way to go, especially
considering the amount of discussions and issues raised.

@ChrysoliteAzalea

In which case, I'd say to feel free to only make the changes that you feel
confident in making before resubmitting and to leave the rest for after
resubmitting, as we might end up discussing them on the pull request anyway.

@kmk3
Copy link
Collaborator

kmk3 commented Feb 16, 2023

@netblue30 on Feb 16:

Landlock support.

I'll start by re-merging #5315 from @ChrysoliteAzalea. Probably there will be
some small changes. A Linux kernel 5.13 or newer will be detected at run
time. Disable the feature and print a warning if the kernel is older.

I had created a landlock_v2 branch and fixed most of the issues in the
original PR. It's from a few months back, so it would have to be rebased.

Agreed on the runtime check; I didn't get around to adding it, so we could use
your version of it.

The idea would be to rebase the landlock_v2 branch and then open it as a PR.
Then after reviewing it with @ChrysoliteAzalea and merging it, we could add
the runtime check and other improvements.

Thoughts?

@glitsj16
Copy link
Collaborator

Adding a reminder about Fix spacing & typo in Landlock section of README.md. Might not be needed anymore depending on how #5315 is re-merged.

@kmk3 kmk3 changed the title [landlock] Leftover from #5315 landlock: Leftover from #5315 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants