Skip to content

CI: drop support for EOL Rubies (< 2.7), add support for Ruby 3.4, shift jRuby support from 9.2/9.3 -> 9.3/9.4 #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

CI: drop support for EOL Rubies (< 2.7), add support for Ruby 3.4, shift jRuby support from 9.2/9.3 -> 9.3/9.4 #148

wants to merge 9 commits into from
+19 −10

Conversation

swiknaba
Copy link

@swiknaba swiknaba commented Aug 2, 2023 •
edited
Loading

  • drop Ruby < 2.7 (keeps 2.7)
  • add Ruby 3.2, 3.3, 3.4
  • shift jruby and truffleruby to support latest 2 versions
  • update CI dependencies
  • cache bundle install to save resources

Thanks for 18 years of active maintenance 🙇

image

olleolleolle
olleolleolle reviewed Oct 11, 2023
View reviewed changes
olleolleolle
olleolleolle reviewed Oct 11, 2023
View reviewed changes
swiknaba and others added 2 commits October 15, 2023 17:33
@swiknaba @olleolleolle
Update .github/workflows/ci.yml
b9479e9 
Co-authored-by: Olle Jonsson <olle.jonsson@gmail.com>
@swiknaba
[suggestion] use setup-ruby bundler cache
78e48e6
@swiknaba
Copy link
Author

@olleolleolle PTAL 🙂 🙇

olleolleolle
olleolleolle reviewed Oct 18, 2023
View reviewed changes
olleolleolle
olleolleolle reviewed Oct 18, 2023
View reviewed changes
@swiknaba swiknaba changed the title CI: update Rubies CI: drop support for unmaintained Rubies (< 2.7), add support for Ruby 3.2 Oct 18, 2023
@swiknaba swiknaba changed the title CI: drop support for unmaintained Rubies (< 2.7), add support for Ruby 3.2 CI: drop support for unmaintained Rubies (< 2.7), add support for Ruby 3.2, shift jRuby support from 9.2/9.3 -> 9.3/9.4 Oct 18, 2023
@swiknaba swiknaba changed the title CI: drop support for unmaintained Rubies (< 2.7), add support for Ruby 3.2, shift jRuby support from 9.2/9.3 -> 9.3/9.4 CI: drop support for EOL Rubies (< 2.7), add support for Ruby 3.2, shift jRuby support from 9.2/9.3 -> 9.3/9.4 Oct 18, 2023
@swiknaba
Copy link
Author

r? @mfazekas

@swiknaba swiknaba mentioned this pull request Aug 14, 2024
Open
@swiknaba swiknaba changed the title CI: drop support for EOL Rubies (< 2.7), add support for Ruby 3.2, shift jRuby support from 9.2/9.3 -> 9.3/9.4 CI: drop support for EOL Rubies (< 2.7), add support for Ruby 3.4, shift jRuby support from 9.2/9.3 -> 9.3/9.4 Aug 22, 2024
@codedeleter
Copy link

If dropping 2.7, would be cool to add spec.required_ruby_version = '>= 2.7.0' to the gemspec too.

@codedeleter
Copy link

Would love to see this branch merged in!

@swiknaba
Copy link
Author

If dropping 2.7, would be cool to add spec.required_ruby_version = '>= 2.7.0' to the gemspec too.

that would be a breaking change; I didn't want to be that harsh in this PR. People still on Ruby < 2.7 might not update any gems though :D

This repo might be dead 🥹

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olleolleolle olleolleolle olleolleolle left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swiknaba @codedeleter @olleolleolle