Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(fastify): Do not crash if enableVersioning is not used #13536

Merged
merged 2 commits into from
Jun 3, 2024
Merged

feat(fastify): Do not crash if enableVersioning is not used #13536

merged 2 commits into from
Jun 3, 2024

Conversation

Fcmam5
Copy link
Contributor

@Fcmam5 Fcmam5 commented May 5, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #13496

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@Fcmam5 Fcmam5 force-pushed the fix/do-not-crash-when_not_using-enabledVersioning branch from b65b496 to c0af8af Compare May 5, 2024 07:26
@coveralls
Copy link

coveralls commented May 5, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9ab9e29c-a6c7-418a-943d-6f81a0507a00

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.124%
Totals Coverage Status
Change from base Build e56f6d99-d9bc-426a-b9ef-ed11406d7e1c: 0.0%
Covered Lines: 6737
Relevant Lines: 7313
💛 - Coveralls

micalevisk
micalevisk reviewed May 5, 2024
View reviewed changes
Copy link
Member

@micalevisk micalevisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we'd have to change the versioningOptions field definition to mark it as optional

@Fcmam5
Copy link
Contributor Author

Fcmam5 commented May 6, 2024

@micalevisk I agree, I just pushed now. Please check again

@Fcmam5 Fcmam5 force-pushed the fix/do-not-crash-when_not_using-enabledVersioning branch from eaf9dc7 to 7a61ecc Compare May 6, 2024 07:42
@kamilmysliwiec kamilmysliwiec mentioned this pull request May 8, 2024
Closed
15 tasks
@Fcmam5 Fcmam5 requested a review from micalevisk May 18, 2024 10:32
@kamilmysliwiec kamilmysliwiec merged commit 2d5a7b8 into nestjs:master Jun 3, 2024
5 checks passed
@kamilmysliwiec
Copy link
Member

LGTM

@bukhosi-eugene-mpande bukhosi-eugene-mpande mentioned this pull request Jun 25, 2024
Merged
@ai-leonid ai-leonid mentioned this pull request Jun 25, 2024
Open
@abjerry97 abjerry97 mentioned this pull request Jun 25, 2024
Open
@wissemmtiri wissemmtiri mentioned this pull request Jun 25, 2024
Open
@Cabreira97 Cabreira97 mentioned this pull request Jun 25, 2024
Merged
@MinhhTien MinhhTien mentioned this pull request Jun 26, 2024
Closed
@sophanorin sophanorin mentioned this pull request Jun 26, 2024
Open
This was referenced Jun 29, 2024
Closed
Merged
Merged
Merged
@LukaszLupa LukaszLupa mentioned this pull request Jun 30, 2024
Closed
@renatosugimoto renatosugimoto mentioned this pull request Jul 1, 2024
Merged
@Cabreira97 Cabreira97 mentioned this pull request Jul 5, 2024
Merged
@bukhosi-eugene-mpande bukhosi-eugene-mpande mentioned this pull request Jul 8, 2024
Closed
@prashant-bankifi prashant-bankifi mentioned this pull request Sep 4, 2024
Open
@wissemmtiri wissemmtiri mentioned this pull request Sep 4, 2024
Open
@katiaipduarte katiaipduarte mentioned this pull request Sep 4, 2024
Open
@unaise97 unaise97 mentioned this pull request Sep 5, 2024
Open
@tajul-saajan tajul-saajan mentioned this pull request Sep 7, 2024
Open
@LukaszLupa LukaszLupa mentioned this pull request Sep 8, 2024
Closed
@carlotiii30 carlotiii30 mentioned this pull request Sep 8, 2024
Open
@katiaipduarte katiaipduarte mentioned this pull request Sep 8, 2024
Open
@renatosugimoto renatosugimoto mentioned this pull request Sep 9, 2024
Closed
@AmineYagoub AmineYagoub mentioned this pull request Sep 12, 2024
Open
@santiagoSS99 santiagoSS99 mentioned this pull request Sep 13, 2024
Open
@AmineYagoub AmineYagoub mentioned this pull request Sep 14, 2024
Open
@santiagoSS99 santiagoSS99 mentioned this pull request Sep 14, 2024
Open
@ilovepixelart ilovepixelart mentioned this pull request Sep 15, 2024
Open
@XavierMP14 XavierMP14 mentioned this pull request Sep 17, 2024
Open
@ilovepixelart ilovepixelart mentioned this pull request Sep 18, 2024
Open
@mauriciocarvalho01 mauriciocarvalho01 mentioned this pull request Sep 19, 2024
Open
@ilovepixelart ilovepixelart mentioned this pull request Sep 19, 2024
Open
@AmineYagoub AmineYagoub mentioned this pull request Sep 20, 2024
Open
@m0hs1ne m0hs1ne mentioned this pull request Sep 21, 2024
Open
@renatosugimoto renatosugimoto mentioned this pull request Sep 22, 2024
Closed
@LukaszLupa LukaszLupa mentioned this pull request Sep 28, 2024
Merged
This was referenced Sep 29, 2024
Closed
Closed
Closed
@origranot origranot mentioned this pull request Oct 2, 2024
Merged
This was referenced Oct 25, 2024
Open
Open
Open
@ajile-in ajile-in mentioned this pull request Nov 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjGam benjGam benjGam approved these changes

@micalevisk micalevisk micalevisk approved these changes

Assignees
No one assigned
Labels
scope: platform type: bug 😭
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Fcmam5 @coveralls @kamilmysliwiec @micalevisk @benjGam