Add parameter to allow setting the puppet user shell command

Author: Aaron Hicks

README.markdown

@@ -32,6 +32,7 @@ The `puppet` class installs puppet from packages available to whichever reposito
 * **user**: Specifies the puppet user account. The default value is `puppet`.
 * **gid**: The primary group identity of the puppet user. The default value is `puppet`.
 * **user_home**: Sets the home directory for the puppet user. The default value is `/var/lib/puppet`.
+* **user_shell**: Sets the shell command for the puppet user. The default value is `/bin/false` which prevents shell access for the puppet user.
 * **conf_dir**: Sets the directory where the puppet configuration file is stored. The default is `/etc/puppet`.
 * **var_dir**: This sets the puppet working directory that contains cached data, configurations and reports. The default is `/var/lib/puppet`.
 * **ssl_dir**: This sets the directory where puppet stores SSL state, including certificates and keys. The default is `/var/lib/puppet/ssl`.
@@ -100,7 +101,7 @@ This class installs a Puppetmaster on [Passenger](https://www.phusionpassenger.c
 * **basemodulepaths**: This expects an array of paths for a Puppetmaster to look for Puppet Modules. This list must include `/usr/share/puppet/modules` and will append it if omitted. The default is undefined, which will revert to the puppet default.
 * **autosign**: This sets the path to either an `autosign.conf` whitelist of approved domain names and globs, or an executable that can verifiy host names for [policy based autosigning](https://docs.puppetlabs.com/puppet/latest/reference/ssl_autosign.html). The default is undefined, which will use the whitelist in `$confdir/autosign.conf` by default.
 * **autosign_conf_path**: This sets the path to the `autosign.conf` whitelist file if the default path of `$confdir/autosign.conf` is not desired.
-* **trusted_node_data*: If set to true this will enable the use of the `$trusted` has in puppet manifests and prevent the `$trusted` hash from being altered or set in manifests. The default setting is false.
+* **trusted_node_data**: If set to true this will enable the use of the `$trusted` has in puppet manifests and prevent the `$trusted` hash from being altered or set in manifests. The default setting is false.
 
 **NOTE**: Setting the `http` report handler without providing a reporting URL to the `reporturl` parameter may lead to unexpected behaviour by the Puppetmaster.
 

manifests/init.pp

@@ -33,6 +33,7 @@
   $user                 = $::puppet::params::user,
   $gid                  = $::puppet::params::gid,
   $user_home            = $::puppet::params::user_home,
+  $user_shell           = $::puppet::params::user_shell,
   $conf_dir             = $::puppet::params::conf_dir,
   $log_dir              = $::puppet::params::log_dir,
   $ssl_dir              = $::puppet::params::ssl_dir,
@@ -120,7 +121,7 @@
     name       => $user,
     gid        => $gid,
     comment    => 'Puppet configuration management daemon',
-    shell      => '/bin/false',
+    shell      => $user_shell,
     home       => $user_home,
     managehome => false,
     require    => Package['puppet'],

manifests/params.pp

@@ -12,6 +12,7 @@
   $user                   = 'puppet'
   $gid                    = 'puppet'
   $user_home              = '/var/lib/puppet'
+  $user_shell             = '/bin/false'
   $log_dir                = '/var/log/puppet'
   $var_dir                = '/var/lib/puppet'
   $ssl_dir                = "${var_dir}/ssl"

metadata.json

@@ -1,6 +1,6 @@
 {
   "name": "Aethylred-puppet",
-  "version": "1.4.2",
+  "version": "1.5.0",
   "author": "Aaron Hicks <aethylred@gmail.com>",
   "license": "Licensed under GPL3",
   "summary": "A Puppet module for installing, configuring and managing puppet, puppetmaster, and hiera.",

spec/classes/init_spec.rb

@@ -276,6 +276,16 @@
         'home'  => '/some/other/path'
       )}
     end
+    describe 'with user_shell => /bin/bash' do
+      let :params do
+        {
+          :user_shell => '/bin/bash',
+        }
+      end
+      it { should contain_user('puppet_user').with(
+        'shell'  => '/bin/bash'
+      )}
+    end
     describe 'with a custom conf_dir' do
       let :params do
         {