Remove defaults for sx/sy in WASM map() function #2132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nesbox
approved these changes
Feb 17, 2023
There was a problem hiding this comment.
I'll merge this PR but I think we have to find a better solution to detect default variables in wasm.
Because I see the same problem for x = -1 or y = -1 for example.
@joshgoebel what do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #2131.
This enables calling
map()from the WASM API with sx or sy=-1, which is consistent with the Lua API.This does not break any of the current languages with templates (C, D, Rust, Zig) because arguments to
map()cannot be omitted. However, for future languages which allow optional arguments, this may require workarounds at the language API level to get sx/sy=0 by default, ifm3ApiGetArg()defaults to -1 on missing arguments (I do not understand howm3ApiGetArg()works, but the other defaults in wasm.c seem to assume aint32_twith a value of-1fromm3ApiGetArg()means a missing argument).