New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make errBuffer pointer, avoid memory bug by not using janet_buffer_init #2095

Merged

nesbox merged 1 commit into nesbox:main from AlecTroemel:janet-buffer-hotfix

Jan 25, 2023

Contributor

AlecTroemel commented Jan 24, 2023 •

edited

Loading

suggestion comes from the creator of janet themselves!

The garbage collector will eventually try to call free(&errBuffer), which will segfault. janet_buffer_init is mean to be used with janet_buffer_deinit
-bakpakin


          make errBuffer pointer, avoid memory bug by not using janet_buffer_init

36717da

AlecTroemel marked this pull request as ready for review

January 24, 2023 14:47

nesbox approved these changes

View reviewed changes

nesbox assigned AlecTroemel

nesbox merged commit 60f2840 into nesbox:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet