Add smooth line drawing in sprite editor #1967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nesbox
reviewed
Jun 27, 2022
| tic_tilesheet_setpix(&sprite->sheet, x+i, y+j, color); | ||
| } | ||
|
|
||
| static void paintLine(Sprite* sprite, u8 color, s32 x1, s32 y1, s32 x2, s32 y2) |
There was a problem hiding this comment.
You can call tic_api_line() instead the own line dwawing implementation.
There was a problem hiding this comment.
Oh, sorry, I see, you draw line depending on brush size.
nesbox
approved these changes
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently when drawing in tic80's sprite editor, only the point at the current mouse position is "stamped", which leads to undesirable gaps in the user's stroke:
this pull request changes the behavior to draw a line between the previous mouse position (now cached as a member of the Sprite struct) and the current one, resulting in an unbroken stroke:
hopefully this change is useful, if there is anything that I should change please feel free to let me know, too.