Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add help topics for keys and buttons #1754

Merged
merged 2 commits into from
Dec 30, 2021
Merged

Add help topics for keys and buttons #1754

merged 2 commits into from
Dec 30, 2021

Conversation

blinry
Copy link
Contributor

@blinry blinry commented Dec 18, 2021

As per #1746, this is an implementation attempt.

screen13

The help for the keys is arranged in two columns to save some space:

screen14
screen15

Open questions:

  • Should the topics be mentioned in the help texts for btn(p) and key(p)? I think probably not – for example, poke also doesn't mention the RAM and VRAM pages.
  • Should the tables have headers, like RAM and VRAM?
  • Should they be included when exporting the help?

@nesbox
Copy link
Owner

nesbox commented Dec 18, 2021

Should the topics be mentioned in the help texts for btn(p) and key(p)? I think probably not – for example, poke also doesn't mention the RAM and VRAM pages.
Should the tables have headers, like RAM and VRAM?

It's up to you :)

Should they be included when exporting the help?

I'd like to see it in the exported help :)

Thanks

@blinry
Copy link
Contributor Author

blinry commented Dec 29, 2021

I added them to the exported help, and I'm happy with this PR as-is! :)

@blinry blinry marked this pull request as ready for review December 29, 2021 18:22
Copy link
Owner

@nesbox nesbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@nesbox nesbox merged commit 4a3fb48 into nesbox:master Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants