Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: integrate WalletConnet #2880

Draft
wants to merge 19 commits into
base: develop
Choose a base branch
from
Draft

feat: integrate WalletConnet #2880

wants to merge 19 commits into from

Conversation

devchenyan
Copy link
Collaborator

@devchenyan devchenyan commented Oct 17, 2023 •
edited
Loading

Screen-2023-10-18-095333.mp4

scan:

Screen-2023-11-01-094739.mp4

homura
homura reviewed Oct 17, 2023
View reviewed changes
packages/neuron-ui/package.json Outdated
@@ -53,6 +53,7 @@
"@nervosnetwork/ckb-sdk-core": "0.109.0",
"@nervosnetwork/ckb-sdk-utils": "0.109.0",
"canvg": "2.0.0",
"ckb-walletconnect-wallet-sdk": "0.0.1-alpha.9",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it would be more convenient to move the SDK to this repository and use the yarn workspace feature, or import the SDK via git submodule. This would simplify development as it would not require publishing every change made to the SDK.

@Keith-CY
Copy link
Collaborator

Keith-CY commented Oct 17, 2023 •
edited by github-actions bot
Loading

/package
Packageing failed in 6545346585. @Keith-CY

@Keith-CY
Copy link
Collaborator

/package Packageing failed in 6545346585. @Keith-CY

Failed to compile at https://github.com/nervosnetwork/neuron/actions/runs/6545346585/job/17773615195#step:15:94

@devchenyan
Copy link
Collaborator Author

devchenyan commented Oct 22, 2023 •
edited by github-actions bot
Loading

/package
Packaging for test is done in 6601527043. @devchenyan

@devchenyan
Copy link
Collaborator Author

devchenyan commented Oct 23, 2023 •
edited by github-actions bot
Loading

/package
Packaging for test is done in 6613859661. @devchenyan

@Keith-CY Keith-CY mentioned this pull request Nov 1, 2023
Closed
@devchenyan
Copy link
Collaborator Author

devchenyan commented Nov 1, 2023 •
edited by github-actions bot
Loading

/package
Packaging for test is done in 6718072848. @devchenyan

@devchenyan devchenyan marked this pull request as ready for review November 14, 2023 04:24
@Keith-CY
Copy link
Collaborator

CI failed

@Keith-CY
Copy link
Collaborator

Cell management has been merged by #2859 and this PR can be resumed

@devchenyan devchenyan marked this pull request as draft November 28, 2023 14:56
@devchenyan
Copy link
Collaborator Author

devchenyan commented Dec 1, 2023 •
edited by github-actions bot
Loading

/package
Packaging for test is done in 7057329140. @devchenyan

@Keith-CY
Copy link
Collaborator

Is this PR ready for review

@devchenyan
Copy link
Collaborator Author

Is this PR ready for review

There's still the transaction details and evoking the phone camera part yet to be done, expect ready for review next week.

@Keith-CY Keith-CY mentioned this pull request Dec 28, 2023
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@homura homura homura left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devchenyan @Keith-CY @homura