Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Impl from into for gen type #4512

Merged
merged 3 commits into from
Sep 4, 2024
Merged

feat: Impl from into for gen type #4512

merged 3 commits into from
Sep 4, 2024

Conversation

driftluo
Copy link
Collaborator

@driftluo driftluo commented Jul 9, 2024 •
edited
Loading

What problem does this PR solve?

  1. impl From/Into for molecule types
  2. remove all pack/unpack used
  3. wait docs: add rust api doc molecule#97 merge, release new version
  4. change the builder function to generics

Check List

Tests

  • Unit test
  • Integration test

Release note

Title Only: Include only the PR title in the release note.

@driftluo driftluo force-pushed the impl-from-into-for-gen-type branch 10 times, most recently from 8f51be1 to 2617762 Compare July 10, 2024 05:42
eval-exec
eval-exec previously approved these changes Jul 10, 2024
View reviewed changes
@eval-exec eval-exec added the t:enhancement Type: Feature, refactoring. label Jul 10, 2024
@driftluo driftluo force-pushed the impl-from-into-for-gen-type branch from 207015d to de866c4 Compare July 12, 2024 06:12
@driftluo driftluo marked this pull request as ready for review July 23, 2024 06:08
@driftluo driftluo requested a review from a team as a code owner July 23, 2024 06:08
@driftluo driftluo requested review from doitian and removed request for a team July 23, 2024 06:08
eval-exec
eval-exec previously approved these changes Jul 24, 2024
View reviewed changes
@driftluo driftluo force-pushed the impl-from-into-for-gen-type branch 5 times, most recently from dd0cb8c to 3a56ea1 Compare July 24, 2024 13:04
@driftluo driftluo force-pushed the impl-from-into-for-gen-type branch 5 times, most recently from 11a9441 to ecbd91f Compare August 14, 2024 08:11
eval-exec
eval-exec previously approved these changes Aug 14, 2024
View reviewed changes
@driftluo driftluo force-pushed the impl-from-into-for-gen-type branch 3 times, most recently from 3853c45 to 6797256 Compare August 14, 2024 09:01
@driftluo driftluo force-pushed the impl-from-into-for-gen-type branch 2 times, most recently from 3c428db to 95b3671 Compare August 27, 2024 05:40
@zhangsoledad zhangsoledad added this pull request to the merge queue Sep 4, 2024
Merged via the queue into nervosnetwork:develop with commit 18c68f5 Sep 4, 2024
32 checks passed
@driftluo driftluo deleted the impl-from-into-for-gen-type branch September 5, 2024 04:52
zhangsoledad added a commit that referenced this pull request Oct 9, 2024
@zhangsoledad
Revert "Merge pull request #4512 from driftluo/impl-from-into-for-gen…
3ec7814 
…-type"

This reverts commit 18c68f5, reversing
changes made to 0274984.
zhangsoledad added a commit that referenced this pull request Oct 9, 2024
@zhangsoledad
Revert "Merge pull request #4512 from driftluo/impl-from-into-for-gen…
9e1ff5c 
…-type"

This reverts commit 18c68f5, reversing
changes made to 0274984.
@zhangsoledad zhangsoledad mentioned this pull request Oct 9, 2024
Merged
zhangsoledad added a commit that referenced this pull request Oct 9, 2024
@zhangsoledad
Revert "Merge pull request #4512 from driftluo/impl-from-into-for-gen…
54d5edb 
…-type"

This reverts commit 18c68f5, reversing
changes made to 0274984.
zhangsoledad added a commit that referenced this pull request Oct 9, 2024
@zhangsoledad
Revert "Merge pull request #4512 from driftluo/impl-from-into-for-gen…
9f170f6 
…-type"

This reverts commit 18c68f5, reversing
changes made to 0274984.
github-merge-queue bot pushed a commit that referenced this pull request Oct 9, 2024
@quake
Merge pull request #4672 from nervosnetwork/zhangsoledad/revert-gen-type
d49cd4e 
Revert "Merge pull request #4512"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eval-exec eval-exec eval-exec approved these changes

@doitian doitian Awaiting requested review from doitian doitian is a code owner automatically assigned from nervosnetwork/ckb-dev

@quake quake Awaiting requested review from quake

@chenyukang chenyukang Awaiting requested review from chenyukang

@zhangsoledad zhangsoledad Awaiting requested review from zhangsoledad

@yangby-cryptape yangby-cryptape Awaiting requested review from yangby-cryptape

Assignees
No one assigned
Labels
t:enhancement Type: Feature, refactoring.
Projects
CKB Kanban
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@driftluo @eval-exec @zhangsoledad