Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add estimate_fee_rate rpc #4465

Closed
wants to merge 1 commit into from

Conversation

quake
Copy link
Member

@quake quake commented May 20, 2024

What problem does this PR solve?

resolve #3673

What is changed and how it works?

Since CKB transaction confirmation involves a two-step process: 1) propose and 2) commit, it is complex to predict the transaction fee accurately with the expectation that it will be included within a certain block height.

This PR relies on two assumptions and uses a simple strategy to estimate the transaction fee: 1) all transactions in the pool are waiting to be proposed, and 2) no new transactions will be added to the pool. In practice, this simple method should achieve good accuracy fee rate and running performance.

The rpc parameter target_to_be_committed is limited to 3~131, because the minimum value of the proposal window is 2, which is equivalent to predicting the height of current_tip + 1 ~ 128.

Check List

Tests

  • Unit test
  • Integration test

Release note

Title Only: Include only the PR title in the release note.

@quake quake requested a review from a team as a code owner May 20, 2024 04:24
@quake quake requested review from zhangsoledad, chenyukang and eval-exec and removed request for a team May 20, 2024 04:24

###### Params

* `target_to_be_committed` - The target block number to be committed, minimum value is 3 and maximum value is 131.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rpc parameter target_to_be_committed is limited to 3~131, because the minimum value of the proposal window is 2, which is equivalent to predicting the height of current_tip + 1 ~ 128.

128+2=130

@quake
Copy link
Member Author

quake commented Jul 19, 2024

merged into #4477

@quake quake closed this Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improved support for transaction fee estimation
3 participants