feat(apex_ls): add vim.lsp.config support #4081
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds lsp config for apex language service
andrewderekjackson
force-pushed
the
feat-apex-ls
branch
from
9a0b224 to
91a5e44
Compare
justinmk
reviewed
Sep 19, 2025
Comment on lines
+38
to
+42
| cmd = function(dispatchers, config) | ||
| local local_cmd = { | ||
| vim.env.JAVA_HOME and (vim.env.JAVA_HOME .. '/bin/java') or 'java', | ||
| '-cp', | ||
| config.apex_jar_path, |
There was a problem hiding this comment.
Interesting approach. And since cmd() gained the config arg, this is much more ergonomic. We should keep this is mind for other configs.
There was a problem hiding this comment.
I can't take any credit for that I'm afraid - the approach was shamefully pillaged from the biome config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds lsp config for apex language service, essentially just converting the existing legacy config to the new format.
#3705