fix(docs): docgen.lua reads from lua/*.lua
#3708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
justinmk
commented
Apr 13, 2025
| ---@brief | ||
| --- | ||
| ---https://github.com/agda/agda-language-server | ||
| -- https://github.com/agda/agda-language-server |
There was a problem hiding this comment.
The indent of all comment lines needs to be the same.
justinmk
commented
Apr 13, 2025
Comment on lines
-96
to
-99
| -- Make sure username doesn't leak into the generated document | ||
| local old_home = vim.env.HOME | ||
| local old_cache_home = vim.env.XDG_CACHE_HOME | ||
| vim.env.HOME = '/home/user' |
There was a problem hiding this comment.
todo: this is still needed. example: jdtls
Problem: Since configs now live in `lsp/`, the docgen needs to be updated. Solution: Read the configs from `lsp/`. Parse the `@brief` docstring to get the docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Since configs now live in
lsp/, the docgen needs to be updated.Solution:
Read the configs from
lsp/. Parse the@briefdocstring to get the docs.followup to #3659 @TheRealLorenz