Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(ImageEditor) Persisted Aspect ratio is not accurately re-calculated in the Cropper #369

Closed
grebaldi opened this issue Oct 25, 2016 · 2 comments
Closed

(ImageEditor) Persisted Aspect ratio is not accurately re-calculated in the Cropper #369

grebaldi opened this issue Oct 25, 2016 · 2 comments
Labels
Bug Label to mark the change as bugfix to validate / retest
Milestone
1.0.0 must haves

Comments

@grebaldi
Copy link
Contributor

grebaldi commented Oct 25, 2016 •
edited by skurfuerst
Loading

<- must-have for 1.0.0

Instead of 16:9 for instance, we get some numbers like 382:147

cropper-aspect-ratio
@grebaldi grebaldi added the Bug Label to mark the change as bugfix label Oct 25, 2016
@grebaldi grebaldi added this to the alpha milestone Oct 25, 2016
@grebaldi grebaldi changed the title (ImageEditor) Aspect ratio dropdown currently not working (ImageEditor) Persisted Aspect ratio is not accurately re-calculated in the Cropper Oct 25, 2016
@skurfuerst skurfuerst modified the milestones: alpha, 1.0.0 must haves Apr 13, 2017
@skurfuerst skurfuerst mentioned this issue Apr 13, 2017
Closed
58 tasks
@Torsten85
Copy link
Contributor

FYI: For the resolution 1146x441, 382:147 is the smallest possible fraction and its not 16:9.
16:9 is 1.777..7778, this is 2.59..

so my guess is that the aspect ratio is calculated correctly.

@mstruebing
Copy link
Contributor

I would say you are right, I've testet it with an aspect ratio of 4:3 and it was displayed correctly, so I'm closing this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Label to mark the change as bugfix to validate / retest
Projects
None yet
Milestone
1.0.0 must haves
Development

No branches or pull requests
4 participants
@skurfuerst @Torsten85 @grebaldi @mstruebing