-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Defer Event (de)normalization #241
Comments
Some more thoughts I had on this one: final class Event {
public function __construct(string $identifier, string $type, array $data, array $metadata)
} (currently final class EventEnvelope {
public function __construct(Event $event, StreamName $streamName, int $version, int $sequenceNumber, \DateTimeInterface $recordedAt)
} when reading events. The conversion from and to |
As for the reasoning:
|
An additional reason:
|
Currently events are converted to an
EventEnvelope
instance (withRawEvent
and the denormalizedDomainEventInterface
instance) when iterating an event stream.Instead the denormalization should only happen when actually required (i.e. when invoking the corresponding
when*()
method).The text was updated successfully, but these errors were encountered: