Heap bitmap scan prefetch fix2 v14 #275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MMeent
approved these changes
Apr 6, 2023
MMeent
pushed a commit
that referenced
this pull request
May 11, 2023
* Copy iterator result in BitmapHeapNext * Restore initial -1 value for prefetch_target * Add tbmres_copy to BitmapHeapScanState
tristan957
pushed a commit
that referenced
this pull request
Aug 10, 2023
* Copy iterator result in BitmapHeapNext * Restore initial -1 value for prefetch_target * Add tbmres_copy to BitmapHeapScanState
tristan957
pushed a commit
that referenced
this pull request
Nov 8, 2023
* Copy iterator result in BitmapHeapNext * Restore initial -1 value for prefetch_target * Add tbmres_copy to BitmapHeapScanState
tristan957
pushed a commit
that referenced
this pull request
Nov 8, 2023
* Copy iterator result in BitmapHeapNext * Restore initial -1 value for prefetch_target * Add tbmres_copy to BitmapHeapScanState
tristan957
pushed a commit
that referenced
this pull request
Feb 5, 2024
* Copy iterator result in BitmapHeapNext * Restore initial -1 value for prefetch_target * Add tbmres_copy to BitmapHeapScanState
tristan957
pushed a commit
that referenced
this pull request
Feb 5, 2024
* Copy iterator result in BitmapHeapNext * Restore initial -1 value for prefetch_target * Add tbmres_copy to BitmapHeapScanState
tristan957
pushed a commit
that referenced
this pull request
Feb 6, 2024
* Copy iterator result in BitmapHeapNext * Restore initial -1 value for prefetch_target * Add tbmres_copy to BitmapHeapScanState
tristan957
pushed a commit
that referenced
this pull request
May 10, 2024
* Copy iterator result in BitmapHeapNext * Restore initial -1 value for prefetch_target * Add tbmres_copy to BitmapHeapScanState
tristan957
pushed a commit
that referenced
this pull request
May 20, 2024
* Copy iterator result in BitmapHeapNext * Restore initial -1 value for prefetch_target * Add tbmres_copy to BitmapHeapScanState
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry, one more bug fix for bitmap heap scan prefetch.
There were actually two errors:
This is why with very small probability, if first element is proceeded not by leader, but by some other parallek worker select_prefetch.sql test may fail (neondatabase/neon#3928)
This PR contain fix of this problem why copying iterators result.
Also optimization of copy is implemented; only actually needed number of item offsets is copied instead of MaxHeapTuplesPerPage