Skip to content

Fix shared memory initialization for last written LSN cache #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 24, 2022
Merged

Fix shared memory initialization for last written LSN cache #226

merged 2 commits into from
Oct 24, 2022

Conversation

knizhnik
Copy link

Replace (from,till) with (from,n_blocks) for SetLastWrittenLSNForBlockRange function

@knizhnik
Fix shared memory initialization for last written LSN cache
4abde95 
Replace (from,till) with (from,n_blocks) for SetLastWrittenLSNForBlockRange function
hlinnaka
hlinnaka approved these changes Oct 23, 2022
View reviewed changes
src/backend/access/transam/xlog.c Outdated
BlockNumber end_bucket; /* exclusive */

start_bucket = from / LAST_WRITTEN_LSN_CACHE_BUCKET;
end_bucket = n_blocks == 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could do the n_blocks == 0 earlier in the function, like we check for lsn == InvalidXLogRecPtr. Might be more clear.

@knizhnik knizhnik merged commit 4e4cb63 into REL_15_STABLE_neon Oct 24, 2022
@knizhnik knizhnik deleted the prefetch_fixes_v15_new branch October 24, 2022 09:14
lubennikovaav pushed a commit that referenced this pull request Nov 21, 2022
@knizhnik @lubennikovaav
Fix shared memory initialization for last written LSN cache (#226)
e0dd8a0 
* Fix shared memory initialization for last written LSN cache

Replace (from,till) with (from,n_blocks) for SetLastWrittenLSNForBlockRange function

* Fast exit from SetLastWrittenLSNForBlockRange for n_blocks == 0
MMeent pushed a commit that referenced this pull request Feb 10, 2023
@knizhnik @MMeent
Fix shared memory initialization for last written LSN cache (#226)
448bafa 
* Fix shared memory initialization for last written LSN cache

Replace (from,till) with (from,n_blocks) for SetLastWrittenLSNForBlockRange function

* Fast exit from SetLastWrittenLSNForBlockRange for n_blocks == 0
MMeent pushed a commit that referenced this pull request May 11, 2023
@knizhnik @MMeent
Fix shared memory initialization for last written LSN cache (#226)
495da6a 
* Fix shared memory initialization for last written LSN cache

Replace (from,till) with (from,n_blocks) for SetLastWrittenLSNForBlockRange function

* Fast exit from SetLastWrittenLSNForBlockRange for n_blocks == 0
tristan957 pushed a commit that referenced this pull request Aug 10, 2023
@knizhnik @tristan957
Fix shared memory initialization for last written LSN cache (#226)
534b38a 
* Fix shared memory initialization for last written LSN cache

Replace (from,till) with (from,n_blocks) for SetLastWrittenLSNForBlockRange function

* Fast exit from SetLastWrittenLSNForBlockRange for n_blocks == 0
tristan957 pushed a commit that referenced this pull request Nov 8, 2023
@knizhnik @tristan957
Fix shared memory initialization for last written LSN cache (#226)
559ee01 
* Fix shared memory initialization for last written LSN cache

Replace (from,till) with (from,n_blocks) for SetLastWrittenLSNForBlockRange function

* Fast exit from SetLastWrittenLSNForBlockRange for n_blocks == 0
tristan957 pushed a commit that referenced this pull request Nov 8, 2023
@knizhnik @tristan957
Fix shared memory initialization for last written LSN cache (#226)
8d7b144 
* Fix shared memory initialization for last written LSN cache

Replace (from,till) with (from,n_blocks) for SetLastWrittenLSNForBlockRange function

* Fast exit from SetLastWrittenLSNForBlockRange for n_blocks == 0
tristan957 pushed a commit that referenced this pull request Nov 8, 2023
@knizhnik @tristan957
Fix shared memory initialization for last written LSN cache (#226)
7552453 
* Fix shared memory initialization for last written LSN cache

Replace (from,till) with (from,n_blocks) for SetLastWrittenLSNForBlockRange function

* Fast exit from SetLastWrittenLSNForBlockRange for n_blocks == 0
tristan957 pushed a commit that referenced this pull request Feb 5, 2024
@knizhnik @tristan957
Fix shared memory initialization for last written LSN cache (#226)
4574b7c 
* Fix shared memory initialization for last written LSN cache

Replace (from,till) with (from,n_blocks) for SetLastWrittenLSNForBlockRange function

* Fast exit from SetLastWrittenLSNForBlockRange for n_blocks == 0
tristan957 pushed a commit that referenced this pull request Feb 5, 2024
@knizhnik @tristan957
Fix shared memory initialization for last written LSN cache (#226)
8633d7a 
* Fix shared memory initialization for last written LSN cache

Replace (from,till) with (from,n_blocks) for SetLastWrittenLSNForBlockRange function

* Fast exit from SetLastWrittenLSNForBlockRange for n_blocks == 0
tristan957 pushed a commit that referenced this pull request Feb 6, 2024
@knizhnik @tristan957
Fix shared memory initialization for last written LSN cache (#226)
2df27d7 
* Fix shared memory initialization for last written LSN cache

Replace (from,till) with (from,n_blocks) for SetLastWrittenLSNForBlockRange function

* Fast exit from SetLastWrittenLSNForBlockRange for n_blocks == 0
tristan957 pushed a commit that referenced this pull request May 10, 2024
@knizhnik @tristan957
Fix shared memory initialization for last written LSN cache (#226)
0d76307 
* Fix shared memory initialization for last written LSN cache

Replace (from,till) with (from,n_blocks) for SetLastWrittenLSNForBlockRange function

* Fast exit from SetLastWrittenLSNForBlockRange for n_blocks == 0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hlinnaka hlinnaka hlinnaka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knizhnik @hlinnaka