Misc cleanup in libpagestore.c. #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We could do a lot more, for the rebranding and cleanup in general. But this is a start. |
MMeent
requested changes
May 16, 2022
contrib/zenith/libpagestore.c
Outdated
| errhidestmt(true), errhidecontext(true))) | ||
|
|
||
| bool connected = false; | ||
| PGconn *pageserver_conn = NULL; | ||
|
|
||
| char *page_server_connstring_raw; | ||
|
|
||
| static ZenithResponse *zenith_call(ZenithRequest *request); | ||
| static ZenithResponse *pageserver_call(ZenithRequest *request); |
There was a problem hiding this comment.
Is the renaming of Zenith[Response, Request] excluded from this patch's efforts?
There was a problem hiding this comment.
Yeah, I left that for another path.
hlinnaka
force-pushed
the
cleanup-libpagestore
branch
from
f5e592f to
a309822
Compare
|
Rebased and fixed the stuff that @MMeent pointed out |
lubennikovaav
approved these changes
Jun 22, 2022
- Fix typos - Change Zenith -> Neon in the ZENITH_SMGR tag that's printed in error messages that is user-visible, and in various function names and comments that are not user-visible. - pgindent - Remove comment about zm_to_string() leaking memory. It doesn't. - Re-word some error messages to match PostgreSQL error message style guide
hlinnaka
force-pushed
the
cleanup-libpagestore
branch
from
a309822 to
5c3925f
Compare
hlinnaka
added a commit
to neondatabase/neon
that referenced
this pull request
Jun 22, 2022
hlinnaka
added a commit
to neondatabase/neon
that referenced
this pull request
Jun 22, 2022
hlinnaka
added a commit
to neondatabase/neon
that referenced
this pull request
Jun 30, 2022
Contains changes from two PRs in vendor/postgres: - neondatabase/postgres#163 - neondatabase/postgres#176
hlinnaka
added a commit
to neondatabase/neon
that referenced
this pull request
Jul 5, 2022
Contains changes from two PRs in vendor/postgres: - neondatabase/postgres#163 - neondatabase/postgres#176
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
messages that is user-visible, and in various function names and comments
that are not user-visible.