Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl Debug for Many Types #269

Open
2 tasks
nixpulvis opened this issue Nov 7, 2017 · 2 comments
Open
2 tasks

impl Debug for Many Types #269

nixpulvis opened this issue Nov 7, 2017 · 2 comments

Comments

@nixpulvis
Copy link

nixpulvis commented Nov 7, 2017

It would help a lot in learning neon if I could type:

println!("{:?}", call.arguments);
// or even...
println!("{:?}", call);

Types referenced:

  • neon::vm::Arguments
  • neon::vm::Call

I'm sure there are a few more types that need Debug as well. I'll try to update this list as I find them.

@dherman
Copy link
Collaborator

dherman commented Nov 17, 2017

I agree they should implement Debug although I'm not sure how useful we can make the output -- in particular I'm trying to figure out whether it's dangerous to actually touch the JS VM at all. If we can't, then we'd only be able to say some very generic (and not super useful) information like struct Arguments {}.

@kjvalencik
Copy link
Member

In addition to Debug, we should eagerly implement other common traits.

https://rust-lang.github.io/api-guidelines/interoperability.html#types-eagerly-implement-common-traits-c-common-traits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants