Skip to content
This repository was archived by the owner on Feb 2, 2021. It is now read-only.

Commit 9806d98

Browse files
author
Giuseppe Aremare
committed
update(core): eslint
1 parent 05073df commit 9806d98

File tree

3 files changed

+29
-20
lines changed

3 files changed

+29
-20
lines changed

.eslintrc.js

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -10,16 +10,11 @@ module.exports = {
1010
"react"
1111
],
1212
"rules": {
13-
"semi": ["error", "never"],
14-
"comma-dangle": ["error", "never"],
15-
"prefer-arrow-callback": 1,
16-
"func-names": 0,
17-
"import/no-extraneous-dependencies": 0,
18-
"no-underscore-dangle": 0,
19-
"no-unused-expressions": 0,
20-
"no-use-before-define": 0,
21-
"react/sort-comp": 0,
22-
"react/no-multi-comp": 0,
23-
"react/require-extension": 0
13+
"comma-dangle": [2,"never"],
14+
"no-duplicate-case": 2,
15+
"no-extra-parens": [2,"all"],
16+
"no-extra-semi": 2,
17+
"linebreak-style": [2,"unix"],
18+
"semi": [2,"never"]
2419
}
2520
};

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,11 @@
3131
"eslint-loader": "^1.6.1",
3232
"eslint-plugin-import": "^2.2.0",
3333
"eslint-plugin-jsx-a11y": "^2.2.3",
34-
"eslint-plugin-react": "^6.8.0",
34+
"eslint-plugin-react": "^6.10.3",
3535
"jest": "^18.1.0",
36+
"mocha": "^3.2.0",
3637
"react-dom": "^15.4.1",
37-
"rimraf": "^2.5.4",
38-
"mocha": "^3.2.0"
38+
"rimraf": "^2.5.4"
3939
},
4040
"peerDependencies": {
4141
"react": ">= 0.11.2 < 16.0.0"

src/ActiveDropdown.jsx

Lines changed: 20 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
11
import React from 'react'
22

3-
export default class ActiveDropdown extends React.Component {
4-
3+
class ActiveDropdown extends React.Component {
54

65
setActiveClass() {
76
if (this.props.activeRoutes.constructor === Array) {
8-
const childRouteIsActive = this.props.activeRoutes.find(element => element == window.location.pathname)
9-
if (childRouteIsActive === undefined) {
10-
return `${this.props.baseClassName}`
7+
const childRouteIsActive = this.props.activeRoutes.find(
8+
element => element === window.location.pathname
9+
)
10+
if (childRouteIsActive !== undefined) {
11+
return `${this.props.baseClassName} active`
1112
}
12-
return `${this.props.baseClassName} active`
1313
}
1414
return `${this.props.baseClassName}`
1515
}
@@ -26,3 +26,17 @@ export default class ActiveDropdown extends React.Component {
2626
)
2727
}
2828
}
29+
30+
ActiveDropdown.defaultProps = {
31+
baseClassName: '',
32+
activeRoutes: []
33+
}
34+
35+
ActiveDropdown.propTypes = {
36+
activeRoutes: React.PropTypes.arrayOf.isRequired,
37+
baseClassName: React.PropTypes.string.isRequired,
38+
title: React.PropTypes.string.isRequired,
39+
children: React.PropTypes.shape.isRequired
40+
}
41+
42+
export default ActiveDropdown

0 commit comments

Comments
 (0)