Skip to content
This repository has been archived by the owner on Apr 30, 2020. It is now read-only.

You can click multiple sections before the drawer closes #59

Closed
javmarina opened this issue Dec 28, 2014 · 9 comments
Closed

You can click multiple sections before the drawer closes #59

javmarina opened this issue Dec 28, 2014 · 9 comments
Labels

Comments

@javmarina
Copy link

In most google apps, when you click a section, the drawer is automatically disabled, avoiding new clicks. Nevertheless, you can click a few sections at once in the example app. That leads to force close (3 sections for me), probably because of an out of memory error.

@neokree
Copy link
Owner

neokree commented Jan 6, 2015

@javmarina the problem is resolved?

@javmarina
Copy link
Author

No

@javmarina
Copy link
Author

What I propose is that when a section is clicked, the first thing done is totally disabling the drawer. When it's closed, the drawer gets enabled again. Right now you can click multiple sections at the same time.

@neokree
Copy link
Owner

neokree commented Jan 7, 2015

yes I know.
I have tried now and you have reason, it isn't disabled.
I done my question because I have implemented a disabling method into the drawer, but seems to have a bug, maybe with the devicemultipaneSupport check.

@javmarina
Copy link
Author

I haven't seen your code. For example, your drawer view is mDrawer. I think you have to call mDrawer.setClickable(false); when a section is clicked and when the drawer is closed call mDrawer.setClickable(true); again

@neokree
Copy link
Owner

neokree commented Jan 20, 2015

no, I disabled all listener using a simple if with boolean parameter. Because I have try but setClickable not work with custom listener on child view. I think the bug persists because this is a time problem. I block all section listeners too late

@egor-n
Copy link

egor-n commented Jan 22, 2015

Google's DrawerLayout cancels children view touches by itself when it is not in the STATE_IDLE. Their approach doesn't work here, because of the MaterialSection's touch behavior. It waits for the ripple effect to finish before doing actual onClick. I've made a separate issue about it - #128.

@mrcasals
Copy link

I'm having the same second problem vedhavyas is facing in #33. Any update on this?

Thanks!

@neokree
Copy link
Owner

neokree commented Jan 31, 2015

I'm working to move the ripple effect to another lib, because this bug is related to some others.
please check this issue #128

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants