Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/expose more properties quick list #5114

Conversation

asmodeus812
Copy link
Contributor

Added some more properties from the quick list to the typings to allow the user to have more contextual information about the ui element and it's state

The method asRelativePath was probably renamed in the past, however
there are extensions such as coc-java which are using the method
named asRelativePath expose the method in the typings api
@asmodeus812 asmodeus812 force-pushed the feature/expose-more-properties-quick-list branch from 38ae73d to e28b8f3 Compare August 21, 2024 10:26
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 98.40%. Comparing base (98fa66a) to head (e28b8f3).
Report is 3 commits behind head on master.

Files Patch % Lines
src/handler/workspace.ts 50.00% 2 Missing ⚠️
src/model/quickpick.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5114      +/-   ##
==========================================
- Coverage   98.41%   98.40%   -0.01%     
==========================================
  Files         273      273              
  Lines       26123    26129       +6     
  Branches     5396     5398       +2     
==========================================
+ Hits        25708    25712       +4     
- Misses        254      257       +3     
+ Partials      161      160       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fannheyward fannheyward merged commit 56ea360 into neoclide:master Aug 26, 2024
4 checks passed
fannheyward added a commit that referenced this pull request Sep 2, 2024
9c25f2f fix(typings): getDocument return type. (#5132)
d4ff928 feat(language-client): modify log time format (#5130)
53e21a9 fix(snippet): deviation in snippet select in the first column (#5104)
0e6a8c7 feat(codeLens): add codeLens.display (#5129)
704295e fix(handler): correct current winid (#5128)
aabfc23 fix: ignore failed config file reads (#5118)
56ea360 feat: expose more properties quick list (#5114)
37f98a1 feat(util): adjust to vim's Patch 9.1.327 (#5122)
80e9f1b chore(package): upgrade micromatch (#5127)
98fa66a chore(packages): lock ESLint versions for now (#5108)
bf3d1f6 Add `coc.preferences.formatterExtension` configuration (#5102)
38697bc chore(handle): typo toggle inlayHint (#5105)
@fannheyward
Copy link
Member

@all-contributors please add @asmodeus812 for code.

Copy link
Contributor

@fannheyward

I've put up a pull request to add @asmodeus812! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants