-
-
Notifications
You must be signed in to change notification settings - Fork 954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/expose more properties quick list #5114
Merged
fannheyward
merged 3 commits into
neoclide:master
from
asmodeus812:feature/expose-more-properties-quick-list
Aug 26, 2024
Merged
Feature/expose more properties quick list #5114
fannheyward
merged 3 commits into
neoclide:master
from
asmodeus812:feature/expose-more-properties-quick-list
Aug 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method asRelativePath was probably renamed in the past, however there are extensions such as coc-java which are using the method named asRelativePath expose the method in the typings api
asmodeus812
force-pushed
the
feature/expose-more-properties-quick-list
branch
from
August 21, 2024 10:26
38ae73d
to
e28b8f3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5114 +/- ##
==========================================
- Coverage 98.41% 98.40% -0.01%
==========================================
Files 273 273
Lines 26123 26129 +6
Branches 5396 5398 +2
==========================================
+ Hits 25708 25712 +4
- Misses 254 257 +3
+ Partials 161 160 -1 ☔ View full report in Codecov by Sentry. |
fannheyward
approved these changes
Aug 26, 2024
fannheyward
added a commit
that referenced
this pull request
Sep 2, 2024
9c25f2f fix(typings): getDocument return type. (#5132) d4ff928 feat(language-client): modify log time format (#5130) 53e21a9 fix(snippet): deviation in snippet select in the first column (#5104) 0e6a8c7 feat(codeLens): add codeLens.display (#5129) 704295e fix(handler): correct current winid (#5128) aabfc23 fix: ignore failed config file reads (#5118) 56ea360 feat: expose more properties quick list (#5114) 37f98a1 feat(util): adjust to vim's Patch 9.1.327 (#5122) 80e9f1b chore(package): upgrade micromatch (#5127) 98fa66a chore(packages): lock ESLint versions for now (#5108) bf3d1f6 Add `coc.preferences.formatterExtension` configuration (#5102) 38697bc chore(handle): typo toggle inlayHint (#5105)
@all-contributors please add @asmodeus812 for code. |
I've put up a pull request to add @asmodeus812! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some more properties from the quick list to the typings to allow the user to have more contextual information about the ui element and it's state