Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Adaptor" spelling is nonstandard (compared to Faraday gem and standard US English) #275

Open
brucek opened this issue Nov 18, 2016 · 1 comment

Comments

@brucek
Copy link
Contributor

brucek commented Nov 18, 2016

The Faraday gem spells adapter with an e. This could lead to some confusion for the fix in #273 as it is unclear if we should use the Neo4j-core or Faraday spelling.

Adapter seems to be used more in US English (but looks to be potentially incorrect in Britain)

Googlefight also agrees with adapter

Since 7.0.0 is a major release, this could be an appropriate time to make such a switch, if desired.

@cheerfulstoic
Copy link
Contributor

I thought about this for a bit before starting on the adaptoers and I was personally more confortable with the "o" (I think mainly because I kept typing it accidentally). But I'm somewhat swayed by your arguments. Curious if @subvertallchris or @ProGM care to comment.

Technically 7.0.0 is a release candidate which means no breaking changes, but I don't know that it would be too big of a deal if it were to change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants