Support in-dev Neo4j version #314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Driver receives Neo4j version in response for INIT message. Released versions have format `Neo4j/X.Y.Z` and in-dev version has `Neo4j/dev`. Previously driver was not able to parse the later and failed. This commit fixes the problem, `ServerVersion` will now be able to represent an in-dev version. Such `ServerVersion` is treated lower than any other version because driver can't know which features it supports and which it does not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Driver receives Neo4j version in response for INIT message. Released versions have format
Neo4j/X.Y.Zand in-dev version hasNeo4j/dev. Previously driver was not able to parse the later and failed.This PR fixes the problem,
ServerVersionwill now be able to represent an in-dev version. SuchServerVersionis treated lower than any other version because driver can't know which features it supports and which it does not.