Use AccessMode correctly in NetworkSession #426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`NetworkSession` acquires connections from the connection pool for the given access mode. Previously it tried to reuse existing connection when available. However, it did not pay attention to access mode when reusing connections. This could result in READ connection being used for WRITE operation and vice versa. This commit fixes the problem by making session buffer existing result, if any. Buffering means that in-use connection will be released back to the pool. It also allows session propagate unconsumed failures from previous query executions.
This was referenced Nov 13, 2017
|
LG |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NetworkSessionacquires connections from the connection pool for the given access mode. Previously it tried to reuse existing connection when available. However, it did not pay attention to access mode when reusing connections. This could result in READ connection being used for WRITE operation and vice versa.This PR fixes the problem by making session buffer existing result, if any. Buffering means that in-use connection will be released back to the pool. It also allows session propagate unconsumed failures from previous query executions.