Fix possible logger leak #362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@if6was9 could you please take a look? I think this change allows us to keep session ids for diagnostics and should fix logger leak. |
|
I think this will fix the GC issue. |
lutovich
force-pushed
the
1.2-fix-log-leak
branch
2 times, most recently
from
ba0cf3f to
91969a5
Compare
Various components like session and connection include their identifiers in logs for diagnostic purposes. Most did this by creating loggers with specialized names. This is a problematic approach because it forces logging framework to create many distinct logger objects. JUL keeps such loggers as weakly referenced values in a map. This caused excessive GC activity and application failures. This commit introduces a logger able to prepend diagnostics to messages and delegate rest of the work. It makes identifiers part of messages. Session, connection and other objects that require identification in logs now use this logger. Example log message: `2017-04-25 02:36:47,319 [ConnectionQueue] [127.0.0.1] Error disposing connection`
lutovich
force-pushed
the
1.2-fix-log-leak
branch
from
91969a5 to
d663077
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various components like session and connection include their identifiers in logs for diagnostic purposes. Most did this by creating loggers with specialized names. This is a problematic approach because it forces logging framework to create many distinct logger objects. JUL keeps such loggers as weakly referenced values in a map. This caused excessive GC activity and application failures.
This PR introduces a logger able to prepend diagnostics to messages and delegate rest of the work. It makes identifiers part of messages. Session, connection and other objects that require identification in logs now use this logger.
Example log message:
2017-04-25 02:36:47,319 [ConnectionQueue] [127.0.0.1] Error disposing connectionRelated to #360
Fixes #359