Create IsoDuration from Period and Duration

Driver represents duration as a custom `IsoDuration` interface. It's a
combination of date-based amount and time-based amount. This commit
makes driver accept `java.time.Period` and `java.time.Duration` as
parameters and convert them to `IsoDuration`.

Author: lutovich

driver/src/main/java/org/neo4j/driver/internal/InternalIsoDuration.java

@@ -18,6 +18,8 @@
  */
 package org.neo4j.driver.internal;
 
+import java.time.Duration;
+import java.time.Period;
 import java.time.temporal.Temporal;
 import java.time.temporal.TemporalUnit;
 import java.time.temporal.UnsupportedTemporalTypeException;
@@ -42,6 +44,16 @@ public class InternalIsoDuration implements IsoDuration
     private final long seconds;
     private final long nanoseconds;
 
+    public InternalIsoDuration( Period period )
+    {
+        this( period.toTotalMonths(), period.getDays(), 0, 0 );
+    }
+
+    public InternalIsoDuration( Duration duration )
+    {
+        this( 0, 0, duration.getSeconds(), duration.getNano() );
+    }
+
     public InternalIsoDuration( long months, long days, long seconds, long nanoseconds )
     {
         this.months = months;

driver/src/main/java/org/neo4j/driver/v1/Values.java

@@ -18,10 +18,12 @@
  */
 package org.neo4j.driver.v1;
 
+import java.time.Duration;
 import java.time.LocalDate;
 import java.time.LocalDateTime;
 import java.time.LocalTime;
 import java.time.OffsetTime;
+import java.time.Period;
 import java.time.ZonedDateTime;
 import java.util.ArrayList;
 import java.util.Arrays;
@@ -107,6 +109,8 @@ public static Value value( Object value )
         if ( value instanceof LocalDateTime ) { return value( (LocalDateTime) value ); }
         if ( value instanceof ZonedDateTime ) { return value( (ZonedDateTime) value ); }
         if ( value instanceof IsoDuration ) { return value( (IsoDuration) value ); }
+        if ( value instanceof Period ) { return value( (Period) value ); }
+        if ( value instanceof Duration ) { return value( (Duration) value ); }
         if ( value instanceof Point2D ) { return value( (Point2D) value ); }
         if ( value instanceof Point3D ) { return value( (Point3D) value ); }
 
@@ -312,6 +316,16 @@ public static Value value( ZonedDateTime zonedDateTime )
         return new DateTimeValue( zonedDateTime );
     }
 
+    public static Value value( Period period )
+    {
+        return value( new InternalIsoDuration( period ) );
+    }
+
+    public static Value value( Duration duration )
+    {
+        return value( new InternalIsoDuration( duration ) );
+    }
+
     public static Value isoDuration( long months, long days, long seconds, long nanoseconds )
     {
         return value( new InternalIsoDuration( months, days, seconds, nanoseconds ) );

driver/src/test/java/org/neo4j/driver/internal/InternalIsoDurationTest.java

@@ -20,7 +20,9 @@
 
 import org.junit.Test;
 
+import java.time.Duration;
 import java.time.LocalDateTime;
+import java.time.Period;
 import java.time.temporal.Temporal;
 import java.time.temporal.UnsupportedTemporalTypeException;
 
@@ -123,6 +125,32 @@ public void shouldImplementEqualsAndHashCode()
         assertEquals( duration1.hashCode(), duration2.hashCode() );
     }
 
+    @Test
+    public void shouldCreateFromPeriod()
+    {
+        Period period = Period.of( 3, 5, 12 );
+
+        InternalIsoDuration duration = new InternalIsoDuration( period );
+
+        assertEquals( period.toTotalMonths(), duration.months() );
+        assertEquals( period.getDays(), duration.days() );
+        assertEquals( 0, duration.seconds() );
+        assertEquals( 0, duration.nanoseconds() );
+    }
+
+    @Test
+    public void shouldCreateFromDuration()
+    {
+        Duration duration = Duration.ofSeconds( 391784, 4879173 );
+
+        InternalIsoDuration isoDuration = new InternalIsoDuration( duration );
+
+        assertEquals( 0, isoDuration.months() );
+        assertEquals( 0, isoDuration.days() );
+        assertEquals( duration.getSeconds(), isoDuration.seconds() );
+        assertEquals( duration.getNano(), isoDuration.nanoseconds() );
+    }
+
     private static IsoDuration newDuration( long months, long days, long seconds, long nanoseconds )
     {
         return new InternalIsoDuration( months, days, seconds, nanoseconds );

driver/src/test/java/org/neo4j/driver/internal/ValuesTest.java

@@ -23,10 +23,12 @@
 import org.junit.Test;
 import org.junit.rules.ExpectedException;
 
+import java.time.Duration;
 import java.time.LocalDate;
 import java.time.LocalDateTime;
 import java.time.LocalTime;
 import java.time.OffsetTime;
+import java.time.Period;
 import java.time.ZonedDateTime;
 import java.util.ArrayDeque;
 import java.util.Collection;
@@ -432,6 +434,34 @@ public void shouldCreateValueFromIsoDuration()
         assertEquals( durationValue1, durationValue2 );
     }
 
+    @Test
+    public void shouldCreateValueFromPeriod()
+    {
+        Period period = Period.of( 5, 11, 190 );
+
+        Value value = value( period );
+        IsoDuration isoDuration = value.asIsoDuration();
+
+        assertEquals( period.toTotalMonths(), isoDuration.months() );
+        assertEquals( period.getDays(), isoDuration.days() );
+        assertEquals( 0, isoDuration.seconds() );
+        assertEquals( 0, isoDuration.nanoseconds() );
+    }
+
+    @Test
+    public void shouldCreateValueFromDuration()
+    {
+        Duration duration = Duration.ofSeconds( 183951, 4384718937L );
+
+        Value value = value( duration );
+        IsoDuration isoDuration = value.asIsoDuration();
+
+        assertEquals( 0, isoDuration.months() );
+        assertEquals( 0, isoDuration.days() );
+        assertEquals( duration.getSeconds(), isoDuration.seconds() );
+        assertEquals( duration.getNano(), isoDuration.nanoseconds() );
+    }
+
     @Test
     public void shouldCreateValueFromPoint2D()
     {