Skip to content

Docs for DEFAULT LANGUAGE #2153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: cypher-25
Choose a base branch
from
Open

Docs for DEFAULT LANGUAGE #2153

wants to merge 11 commits into from
+290 −937

Conversation

mnd999
Copy link
Contributor

@mnd999 mnd999 commented Feb 25, 2025 •
edited by Hunterness
Loading

Builds on #2132

Depends on neo4j/docs-cypher#1123

Not ready yet

@mnd999 mnd999 force-pushed the dev-default-language branch from 8c1daaa to e96937a Compare February 25, 2025 16:54
@JPryce-Aklundh JPryce-Aklundh mentioned this pull request Feb 26, 2025
Open
Hunterness
Hunterness reviewed Feb 26, 2025
View reviewed changes
Copy link
Contributor

@Hunterness Hunterness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments around the documentation, but it also raised some questions regarding implementation 🙈

modules/ROOT/pages/database-administration/standard-databases/listing-databases.adoc
+----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| name | type | aliases | access | databaseID | serverID | address | role | writer | requestedStatus | currentStatus | statusMessage | default | home | currentPrimariesCount | currentSecondariesCount | requestedPrimariesCount | requestedSecondariesCount | creationTime | lastStartTime | lastStopTime | store | lastCommittedTxn | replicationLag | constituents | defaultLanguage | options |
+----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| "movies" | "standard" | ["films", "motion pictures"] | "read-write" | "C066801F54B44EA1520F0FE392B4005AABF42D8DD0A5FD09969B955575D287D5" | "e3063985-e2f4-4728-824b-a7d53779667a" | "localhost:7687" | "primary" | TRUE | "online" | "online" | "" | FALSE | FALSE | 1 | 0 | 1 | 0 | 2023-08-14T10:01:29.074Z | 2023-08-14T10:01:29.074Z | NULL | "record-aligned-1.1" | 3 | 0 | [] | "CYPHER 5" | {} |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will we need to update this to CYPHER 25 when we set the setting to that?

Copy link
Contributor Author

@mnd999 mnd999 Feb 26, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just an example, I don't think it really matters which value we use as long as it is valid.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if we have testing of these files but if so that might start failing since I don't think we explicitly set the default language and therefore it'll likely switch 🤷

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this is verified or not, perhaps someone from the docs team knows.

@renetapopova renetapopova self-requested a review February 27, 2025 10:30
@neo-technology-commit-status-publisher
Copy link
Collaborator

This PR includes documentation updates
View the updated docs at https://neo4j-docs-operations-2153.surge.sh

Updated pages:

Hunterness
Hunterness reviewed Apr 2, 2025
View reviewed changes
Copy link
Contributor

@Hunterness Hunterness left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From when I added the optional keywords OBS ONLY FOR CYPHER 25

Should probably follow whatever we end up doing in #2216

@Hunterness Hunterness mentioned this pull request Apr 4, 2025
Merged
@Hunterness Hunterness changed the base branch from dev to cypher-25 April 4, 2025 12:14
mnd999 and others added 10 commits April 4, 2025 14:17
@mnd999 @Hunterness
WIP default language docs
d8daad0
@mnd999 @Hunterness
WIP default language docs
ca3bb15
@mnd999 @Hunterness
WIP default language docs
1dbf83f
@mnd999 @Hunterness
Update modules/ROOT/pages/database-administration/standard-databases/…
706ff0a 
…listing-databases.adoc

Co-authored-by: Therese Magnusson <scout.therese@gmail.com>
@Hunterness
Add some sentences about default language and aliases
9372ad9
@Hunterness
Add info about default language clauses for aliases
d86efda
@Hunterness
Document ALTER COMPOSITE DATABASE privilege
9577cbd 
also update to not say we can manage aliases using the database management privileges
@Hunterness
Fixing smaller review comments
d55d9df
@Hunterness
See if adding width makes the images visible
a961af5
@Hunterness
Update to handle the different syntaxes depending on cypher version
da953a7 
needed some updates after the rebase

also added alter composite database as its own section in the syntax chapter
@Hunterness Hunterness force-pushed the dev-default-language branch from bc6eca8 to da953a7 Compare April 4, 2025 12:26
Hunterness
Hunterness reviewed Apr 7, 2025
View reviewed changes
modules/ROOT/pages/database-administration/composite-databases/alter-composite-databases.adoc
[[composite-databases-alter]]
= Alter composite databases

Composite databases can be altered using `ALTER DATABASE`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to have a link to the alter standard database page here?

we don't seem to have links to the create/delete standard db pages from the composite db pages so maybe not 🤷

@renetapopova
Copy link
Collaborator

@mnd999, @Hunterness, is this PR ready for docs' review?

@Hunterness
Copy link
Contributor

@renetapopova I think it might depend on what we decide on neo4j/docs-cypher#1123, if some of those parts should move from there to here? I think its fine for you to look it over as I believe all the things we want to cover is covered either here or by linking to that PR currently.

Don't know if Mark have any other view of things 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hunterness Hunterness Hunterness left review comments

@renetapopova renetapopova Awaiting requested review from renetapopova

Assignees

@Hunterness Hunterness

Labels
Cypher 25 Dependencies w. other PR dev DO NOT MERGE team-cypher-operations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mnd999 @neo-technology-commit-status-publisher @renetapopova @Hunterness