data importer with format fixes #1301
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
prakriti-solankey
requested review from
Copilot,
praveshkumar1988 and
kaustubh-darekar
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new data importer option for handling graph schema JSON files, improving support for diverse data sources and updating the state management and UI accordingly.
- Implements URL validation for the data importer
- Adds new constants, types, and context state properties for the importer
- Integrates new UI components for JSON upload and schema extraction
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/src/utils/Utils.ts | Added URL validation utility for the importer |
| frontend/src/utils/Constants.ts | Extended constants with new keys for the data importer UI |
| frontend/src/types.ts | Added new types and updated context definitions for the importer |
| frontend/src/context/UsersFiles.tsx | Updated state initialization and added importer dialog state |
| Various UI components | Integrated data importer functionality into schema selection and upload flows |
| New DataImporter component | Added a new dialog component to handle JSON upload and schema extraction |
| frontend/src/components/Layout/PageLayout.tsx | Hooked up the data importer dialog and updated state management |
| ) => void; | ||
| } | ||
|
|
||
| const DataImporterSchemaDailog = ({ open, onClose, onApply }: DataImporterDialogProps) => { |
There was a problem hiding this comment.
The component name 'DataImporterSchemaDailog' appears to have a typographical error; consider renaming it to 'DataImporterSchemaDialog' for consistency.
| const DataImporterSchemaDailog = ({ open, onClose, onApply }: DataImporterDialogProps) => { | |
| const DataImporterSchemaDialog = ({ open, onClose, onApply }: DataImporterDialogProps) => { |
Copilot uses AI. Check for mistakes.
| @@ -288,6 +320,16 @@ export default function NewEntityExtractionSetting({ | |||
| openLoadSchema(); | |||
| }, []); | |||
|
|
|||
| const onDataImporterSchemaCLick: MouseEventHandler<HTMLButtonElement> = useCallback(async () => { | |||
There was a problem hiding this comment.
The callback name 'onDataImporterSchemaCLick' contains an unexpected capital letter in 'CLick'; consider renaming it to 'onDataImporterSchemaClick' for clarity.
Copilot uses AI. Check for mistakes.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This PR adds a new importer option to handle graph schema data from JSON files. Key changes include:
Implementation of URL validation for the new importer in Utils.ts.
Addition of new constants, types, and state management properties for data importer functionality.
Integration of UI components for importing JSON data and updating graph schema settings.