Skip to content

Commit 39ae046

Browse files
aashipandyakartikpersistent
authored andcommitted
Total pages in buckets (#431)
* page number NA for buckets * added N/A for gcs and s3 pages * total pages for gcs * remove unwanted logger --------- Co-authored-by: kartikpersistent <101251502+kartikpersistent@users.noreply.github.com>
1 parent bff2fb1 commit 39ae046

File tree

6 files changed

+9
-8
lines changed

6 files changed

+9
-8
lines changed

backend/src/main.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ def create_source_node_graph_url_s3(graph, model, source_url, aws_access_key_id,
4444
obj_source_node.file_type = 'pdf'
4545
obj_source_node.file_size = file_info['file_size_bytes']
4646
obj_source_node.file_source = source_type
47-
obj_source_node.total_pages = 1
47+
obj_source_node.total_pages = 'N/A'
4848
obj_source_node.model = model
4949
obj_source_node.url = str(source_url+file_name)
5050
obj_source_node.awsAccessKeyId = aws_access_key_id
@@ -74,7 +74,7 @@ def create_source_node_graph_url_gcs(graph, model, gcs_project_id, gcs_bucket_na
7474
obj_source_node.file_size = file_metadata['fileSize']
7575
obj_source_node.url = file_metadata['url']
7676
obj_source_node.file_source = source_type
77-
obj_source_node.total_pages = 1
77+
obj_source_node.total_pages = 'N/A'
7878
obj_source_node.model = model
7979
obj_source_node.file_type = 'pdf'
8080
obj_source_node.gcsBucket = gcs_bucket_name

frontend/src/components/Chatbot.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import React, { useEffect, useRef, useState } from 'react';
22
import { Button, Widget, Typography, Avatar, TextInput, IconButton, Modal, useCopyToClipboard } from '@neo4j-ndl/react';
33
import {
4-
InformationCircleIconOutline,
54
XMarkIconOutline,
65
ClipboardDocumentIconOutline,
76
SpeakerWaveIconOutline,
@@ -38,7 +37,7 @@ const Chatbot: React.FC<ChatbotProps> = (props) => {
3837
const [copyMessageId, setCopyMessageId] = useState<number | null>(null);
3938

4039
const [value, copy] = useCopyToClipboard();
41-
const { speak, cancel, supported } = useSpeechSynthesis({
40+
const { speak, cancel } = useSpeechSynthesis({
4241
onEnd: () => {
4342
setListMessages((msgs) => msgs.map((msg) => ({ ...msg, speaking: false })));
4443
},

frontend/src/components/Content.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ const Content: React.FC<ContentProps> = ({ isLeftExpanded, isRightExpanded }) =>
174174
if (apiResponse?.status === 'Failed') {
175175
let errorobj = { error: apiResponse.error, message: apiResponse.message, fileName: apiResponse.file_name };
176176
throw new Error(JSON.stringify(errorobj));
177-
} else if (fileItem.total_pages != undefined && (fileItem.total_pages === 'NA' || fileItem.total_pages < 20)) {
177+
} else if (fileItem.total_pages != undefined && (fileItem.total_pages === 'N/A' || fileItem.total_pages < 20)) {
178178
setFilesData((prevfiles) => {
179179
return prevfiles.map((curfile) => {
180180
if (curfile.name == apiResponse?.data?.fileName) {

frontend/src/components/GCSModal.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ const GCSModal: React.FC<GCSModalProps> = ({ hideModal, open, openGCSModal }) =>
8686
gcsBucket: item.gcsBucketName,
8787
gcsBucketFolder: item.gcsBucketFolder,
8888
google_project_id: item.gcsProjectId,
89-
total_pages: 'NA',
89+
total_pages: 'N/A',
9090
id: uuidv4(),
9191
access_token: codeResponse.access_token,
9292
...defaultValues,
@@ -104,6 +104,7 @@ const GCSModal: React.FC<GCSModalProps> = ({ hideModal, open, openGCSModal }) =>
104104
fileSource: defaultValues.fileSource,
105105
processingProgress: defaultValues.processingProgress,
106106
access_token: codeResponse.access_token,
107+
total_pages:"N/A"
107108
});
108109
}
109110
});

frontend/src/components/S3Modal.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ const S3Modal: React.FC<S3ModalProps> = ({ hideModal, open }) => {
8484
name: item.fileName,
8585
size: item.fileSize,
8686
source_url: item.url,
87-
total_pages: 'NA',
87+
total_pages: 'N/A',
8888
id: uuidv4(),
8989
...defaultValues,
9090
});
@@ -100,6 +100,7 @@ const S3Modal: React.FC<S3ModalProps> = ({ hideModal, open }) => {
100100
model: defaultValues.model,
101101
fileSource: defaultValues.fileSource,
102102
processingProgress: defaultValues.processingProgress,
103+
total_pages:"N/A"
103104
});
104105
}
105106
});

frontend/src/types.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ export interface CustomFileBase extends Partial<globalThis.File> {
2626
}
2727
export interface CustomFile extends CustomFileBase {
2828
id: string;
29-
total_pages: number | 'NA';
29+
total_pages: number | 'N/A';
3030
}
3131

3232
export interface OptionType {

0 commit comments

Comments
 (0)