Implement new Javascript test case sync mechanism #328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new 3 way sync mechanism, where the test definitions (Asciidoc), that are generated from neo4j graphql (js) are stored separately as `*.js.adoc`. The new tool JsTestCaseSync.kt now compares the js version with the previous js version and only take over test that were changed. Additionally, the reformatting feature is extracted from the TestSuites into a new tool AsciidocReformater.kt. This removes code that is not test relevant out of the test factories. As a refactoring, utility functions were also removed from the test factories into own *Utils classes.
Andy2003
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new 3 way sync mechanism, where the test definitions (Asciidoc), that are generated from neo4j-graphql (js) are stored separately as
*.js.adoc.The new tool JsTestCaseSync.kt now compares the js version with the previous js version and only take over test that were changed. Additionally, the reformatting feature is extracted from the TestSuites into a new tool AsciidocReformater.kt. This removes code that is not test relevant out of the test factories.
As a refactoring, utility functions were also removed from the test factories into own *Utils classes.